Reading from remote location fails if relative refs are involved

[marcelstoer]

Reading a Swagger definition from a remote location fails if it contains relative refs (at the same location). This seems very much related to what @fehguy addressed in #338. I'm on v1.0.34.

I've got a Swagger file at https://somehost/src/main/resources/services/broker-monitor/v1/broker-monitor-service.yaml.

It contains the following snippet

...
definitions:
  SomeObject:
    type: object
    ...
      message:
        $ref: '../../../technical-definitions/error-handling/v2/error-model.yaml#/definitions/GeneralError'

That referenced definition resides at https://somehost/src/main/resources/technical-definitions/error-handling/v2/error-model.yaml.

If both files are on the local file system then all is well, but reading from the remote location fails with

Caused by: java.lang.ArrayIndexOutOfBoundsException
	at java.lang.System.arraycopy(Native Method)
	at io.swagger.parser.util.RefUtils.buildUrl(RefUtils.java:113)
	at io.swagger.parser.util.RefUtils.readExternalUrlRef(RefUtils.java:68)

The comment at

swagger-parser/modules/swagger-parser/src/main/java/io/swagger/parser/util/RefUtils.java

Line 62 in e8cb13e

//its assumed to be a relative ref

is correct: it is a relative reference. The problem is that it's treated like a local relative reference.

[gracekarina]

Hi @marcelstoer, the urls are broken, can you please add the files. thanks!

[beikov]

Seems like a duplicate of #750

[frantuma]

fixed by #2082