Wording of "Done" Button => "Cancel"

[hoereth]

Version: [ 2.8.0]

What kind of issue is this? Change Request.

We experienced usability issues with the springfox-swagger-ui. The authorization window shows a "Done" button (see screenshot) which acts like a "Cancel" button. I like to suggest to rename it, because users might be tempted to click "Done" to perform the authorization. In fact they should click "Authorize". You would improve awareness by renaming "Done" to "Cancel".

[charlescapps]

This is funny. We have a usability issue at our company --- if there isn't a Done button. The problem is that after you are done authorizing, it's confusing that there's just a Logout button and an x. Many users will just click logout because it's the big button present, and it's not 100% clear that clicking the x will let you keep your authentication.

I put up a PR to add the Done button to the OAuth dialog where it's currently missing, see #4212

I would suggest we arrive at a compromise, either
A) The Done button is only present after you have at least one authorization (to solve both of our issues)
B) We could just make it configurable whether or not there's a Done button. I could adjust my PR to make it a config option that's off by default.
C) The Done button is called Cancel initially, but after you have authorizations it's then called Done

Thoughts?

[hoereth]

I understand that "Cancel" can also be misleading. The button seems to have been introduced as "Close" action. It seems that "Close" could serve both parties. (?) :)

[charlescapps]

I'd be fine with Close if that's cool with you, @hoereth . I can update my pull request to call it Close instead of Done. I'll do so now!

Thanks for finding such an easy compromise. Cheers!

[charlescapps]

OK, #4212 should satisfy this feature request now I believe.

[hoereth]

@charlescapps : thank you! :)