Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement for PR #1387: evaluate const across packages #1388

Merged
merged 7 commits into from
Nov 22, 2022
Merged

Conversation

sdghchj
Copy link
Member

@sdghchj sdghchj commented Nov 20, 2022

Describe the PR
Enhancement for PR #1387: evaluate const across packages

Relation issue
#1367

@codecov
Copy link

codecov bot commented Nov 20, 2022

Codecov Report

Base: 95.60% // Head: 95.20% // Decreases project coverage by -0.39% ⚠️

Coverage data is based on head (4c3e8af) compared to base (e6723fe).
Patch coverage: 85.18% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1388      +/-   ##
==========================================
- Coverage   95.60%   95.20%   -0.40%     
==========================================
  Files          16       15       -1     
  Lines        3023     3048      +25     
==========================================
+ Hits         2890     2902      +12     
- Misses         74       84      +10     
- Partials       59       62       +3     
Impacted Files Coverage Δ
packages.go 89.93% <79.06%> (-2.14%) ⬇️
package.go 88.29% <85.13%> (-11.71%) ⬇️
gen/gen.go 93.48% <100.00%> (+0.03%) ⬆️
generics.go 100.00% <100.00%> (ø)
generics_other.go 100.00% <100.00%> (ø)
parser.go 94.03% <100.00%> (+0.03%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sdghchj sdghchj requested a review from ubogdan November 21, 2022 02:11
@nicolasassi
Copy link

LGTM

@sdghchj sdghchj merged commit e5d507d into master Nov 22, 2022
@sdghchj sdghchj deleted the enums branch November 22, 2022 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants