Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete swag cli section #330

Closed
wants to merge 3 commits into from
Closed

delete swag cli section #330

wants to merge 3 commits into from

Conversation

pei0804
Copy link
Member

@pei0804 pei0804 commented Mar 20, 2019

Describe the PR
ref #325 (comment)

@pei0804
Copy link
Member Author

pei0804 commented Mar 20, 2019

@easonlin404 plz review.

@codecov-io
Copy link

codecov-io commented Mar 20, 2019

Codecov Report

Merging #330 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #330   +/-   ##
=====================================
  Coverage      87%    87%           
=====================================
  Files           7      7           
  Lines        1277   1277           
=====================================
  Hits         1111   1111           
  Misses        103    103           
  Partials       63     63

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93d87f4...e5f0b42. Read the comment docs.

Copy link
Member

@easonlin404 easonlin404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can consider about using other good approach to show cli options. It's NOT user friendly to find how to use by searching help tag issues.

@pei0804
Copy link
Member Author

pei0804 commented Mar 21, 2019

Change every time you change?

@pei0804
Copy link
Member Author

pei0804 commented Mar 21, 2019

OK. I understand.
#331 (comment)

I will request add README from next PR to creator.

@pei0804 pei0804 closed this Mar 21, 2019
@pei0804 pei0804 deleted the delete-swag-cli-section branch March 21, 2019 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants