Support parse definition in vendor, for issues/242 #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #331 +/- ##
==========================================
+ Coverage 87% 87.02% +0.02%
==========================================
Files 7 7
Lines 1277 1279 +2
==========================================
+ Hits 1111 1113 +2
Misses 103 103
Partials 63 63
Continue to review full report at Codecov.
|
pei0804
reviewed
Mar 20, 2019
| @@ -59,6 +61,10 @@ func main() { | |||
| Value: "./docs", | |||
| Usage: "Output directory for al the generated files(swagger.json, swagger.yaml and doc.go)", | |||
| }, | |||
| cli.BoolFlag{ | |||
There was a problem hiding this comment.
What do you think?
@easonlin404
pei0804
reviewed
Mar 20, 2019
|
LGTM |
pei0804
approved these changes
Mar 21, 2019
|
Thx! |
|
@a180285 @pei0804 would you help add |
Closed
|
@a180285 |
|
I forget to update the doc before you notice me. I can update docs tomorrow. If you are urgent to update the doc, you can help to update it. |
|
OK I write. |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
Support parse definition in vendor, for issues/242
#242
Relation issue
#242
Additional context
I found that this tool can work well, expect for parsing this file: https://github.com/swaggo/swag/blob/master/operation.go
Which file is in this repo~~ So I ignored this repo when parse vendor folder