Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support @x- attributes for operations #452

Merged

Conversation

yutopp
Copy link
Contributor

@yutopp yutopp commented Jul 15, 2019

Describe the PR
Add support @x- attributes for operations in paths section. (https://swagger.io/docs/specification/2-0/swagger-extensions/)

Relation issue
#398. This PR introduces additional supports for it.

Additional context
(none)

Thanks.

@codecov-io
Copy link

codecov-io commented Jul 15, 2019

Codecov Report

Merging #452 into master will increase coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #452      +/-   ##
==========================================
+ Coverage   83.27%   83.36%   +0.09%     
==========================================
  Files           7        7              
  Lines        1459     1467       +8     
==========================================
+ Hits         1215     1223       +8     
  Misses        138      138              
  Partials      106      106
Impacted Files Coverage Δ
operation.go 86.2% <100%> (+0.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6de832a...f85ce40. Read the comment docs.

Copy link
Member

@easonlin404 easonlin404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like don't need to commit go.mod and go.sum files because no new libraries be imported.

@yutopp
Copy link
Contributor Author

yutopp commented Jul 15, 2019

Thank you for your review. I fixed that. f85ce40

Copy link
Member

@easonlin404 easonlin404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@easonlin404 easonlin404 merged commit 4642ffd into swaggo:master Jul 16, 2019
@easonlin404
Copy link
Member

@yutopp Thanks four your contributions.

@yutopp yutopp deleted the feature/support_extensions_for_operations branch July 16, 2019 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants