Deps: switch from Unicorn to Puma #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pushing up the PR, but I want to run this on Heroku for a couple of weeks before merging. |
**What** This switches the server we use from Unicorn to Puma **Why** * Puma is the blessed option [on Heroku][heroku]. * It [works with Capybara][capybara] out of the box. * Ruby 3 [removes `webrick`][ruby3] from the core libraries, so we would need to add it as a dependency for Capybara when upgrading. Might as well consolidate on a single server. **Notes** I also moved `pg` out of the `production` group. [heroku]: https://devcenter.heroku.com/articles/deploying-rails-applications-with-the-puma-web-server#recommended-default-puma-process-and-thread-configuration [capybara]: https://github.com/teamcapybara/capybara#drivers [ruby3]: https://www.ruby-lang.org/en/news/2020/12/25/ruby-3-0-0-released/
|
I've been testing this for the better part of a year and it hasn't had any issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This switches the server we use from Unicorn to Puma
Why
webrickfrom the core libraries, so we wouldneed to add it as a dependency for Capybara when upgrading. Might as
well consolidate on a single server.
Notes
I also moved
pgout of theproductiongroup.