Remove warp dependency from engine #2122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...just for one type-alias: ```Haskell type Port = Int ``` * part of #2109
byorgey
approved these changes
Aug 16, 2024
| @@ -43,7 +42,7 @@ import Swarm.Util.Lens (makeLensesNoSigs) | |||
| import Swarm.Version (NewReleaseFailure (..)) | |||
|
|
|||
| data RuntimeState = RuntimeState | |||
| { _webPort :: Maybe Port | |||
| { _webPort :: Maybe Int | |||
There was a problem hiding this comment.
How about keeping this as Port and defining type Port = Int locally?
There was a problem hiding this comment.
Sure, but it seems unnecessary as we only use it to make an informational widget.
The lens is very explicitly named and port does not have any special operations like say IP adress.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...just for one type-alias: