Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config modes #173

Merged
merged 3 commits into from
Sep 7, 2015
Merged

config modes #173

merged 3 commits into from
Sep 7, 2015

Conversation

taiyu-len
Copy link
Collaborator

config modes are done.

mode "mode_name" {
    whatever bindings you want go here
    bindsym mode default # default is the default mode name
}

lots of changes here and there.
commands no longer have config as an argument, no more temp_config stuff so its not needed.
cleanedup the split_directive, renamed to split_args, along with a free_args
and a few other functions here and there cleanedup.

ddevault
ddevault reviewed Sep 7, 2015
View reviewed changes
sway/commands.c
// Create mode if it doesnt exist
if (!mode && argc >= 2 && strncmp(argv[1],"{",1) == 0) {
mode = malloc(sizeof*mode);
mode->name = malloc(strlen(mode_name) + 1);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use strdup

@ddevault
Copy link
Contributor

ddevault commented Sep 7, 2015

Looks good for the most part. Let me know when you fix the minor issues.

@taiyu-len
Copy link
Collaborator Author

done, also used strdup in some other places.

ddevault added a commit that referenced this pull request Sep 7, 2015
@ddevault
Merge pull request #173 from taiyu-len/config_mode
7654f5e 
config modes
@ddevault ddevault merged commit 7654f5e into swaywm:master Sep 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taiyu-len @ddevault