Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix handling key modifiers if not pressed at first #2172

Merged
merged 1 commit into from
Jun 28, 2018
Merged

fix handling key modifiers if not pressed at first #2172

merged 1 commit into from
Jun 28, 2018

Conversation

apreiml
Copy link
Contributor

@apreiml apreiml commented Jun 28, 2018

fixes #2169

@ddevault
Copy link
Contributor

LGTM but I'll have to test it when I get home from work

@emersion
Copy link
Member

@frsfnrrg Thoughts?

ddevault
ddevault approved these changes Jun 28, 2018
View reviewed changes
Copy link
Contributor

@ddevault ddevault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed this fixes the problem for me

@ddevault
Copy link
Contributor

Got annoyed enough by this problem at work to test this out now 😉

@ddevault ddevault merged commit d3ea07f into swaywm:master Jun 28, 2018
@emersion
Copy link
Member

Thanks!

@apreiml apreiml deleted the fix-keybinding-modifier-handling branch June 29, 2018 05:52
@frsfnrrg
Copy link
Contributor

@frsfnrrg Thoughts?

The previous behaviour was a rewriting artifact that I didn't catch, and in retrospect, definitely a bug.

The changes work as advertised.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddevault ddevault ddevault approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Key bindings not recognized if non-modifier keys were held first
4 participants
@apreiml @ddevault @emersion @frsfnrrg