Rename sway_root.outputs to sway_root.all_outputs #2513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddevault
reviewed
Aug 25, 2018
include/sway/tree/root.h
Outdated
| @@ -21,7 +21,7 @@ struct sway_root { | |||
|
|
|||
| struct wlr_texture *debug_tree; | |||
|
|
|||
| struct wl_list outputs; // sway_output::link | |||
| struct wl_list all_outputs; // sway_output::link | |||
There was a problem hiding this comment.
Can you add a comment here clarifying what kind of outputs are included here? Then you don't need to change the variable name at all.
This list includes disabled outputs. When sway_container is demoted, we'll need to store the root's children (ie. enabled outputs) in the sway_root. It makes sense to put these in a list called `outputs`, so I'm renaming the existing list in advance.
RyanDwyer
force-pushed
the
rename-root-outputs
branch
from
3ea2198
to
1e024b9
Compare
RedSoxFan
approved these changes
Aug 26, 2018
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This list includes disabled outputs.
When
sway_containeris demoted, we'll need to store the root's children (ie. enabled outputs) in thesway_root. It makes sense to put these in a list calledoutputs, so I'm renaming the existing list in advance.