swaybar: disallow left and right position and print error on default

[Emantor]

The positions "left" and "right" are not allowed by the man page, remove them
from the allowed positions. Also print an error to stderr if we default to the
bottom position.

Fixes #2878

[Emantor]

@ianyfan We could also exit instead of defaulting to bottom, I decided to keep the existing behaviour here. What is your opinion on that?

[ianyfan]

The check should really occur in commands/bar/position.c, and default to bottom on error. Then, there should be no chance of swaybar starting with an invalid position. So really, the else block shouldn't be needed, but for sanity, you could keep this. But use wlr_log instead of fprintf.

[Emantor]

I think both should be removed. I'll add the wlr_log for commands/bar/position.c, but I don't think that will work for swaybar, since afaik wlr_log is only available to the compositor. I think printing to stderr is the right call there.

[emersion]

afaik wlr_log is only available to the compositor

It's also available in clients. But it makes clients link with wlroots, which is not great.

[Emantor]

Swaybar does currently not link against wlroots, so i'd like to avoid that dependency.

[Emantor]

I removed the allowed positions from sways command. The command already returns an error for invalid positions, so imo no change is needed there. Should be ready for review.

[RyanDwyer]

Swaybar does currently not link against wlroots

I don't know where you're getting your information from. It's linked in swaybar/meson.build, and if you search the swaybar directory for wlr_log you'll see it's used dozens of times.

[Emantor]

Swaybar does currently not link against wlroots

I don't know where you're getting your information from. It's linked in swaybar/meson.build, and if you search the swaybar directory for wlr_log you'll see it's used dozens of times.

I did rg "wlr*.h" in the swaybar directory, however * does not match / and since the include path is wlr/util/log.h I assumed that swaybar is not linked against wlroots, since my grep returned no matches.

I replaced the fprintf with wlr_log, sorry for the noise.

Stale

[emersion]

Thanks!