Replace _XOPEN_SOURCE with _POSIX_C_SOURCE #3185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
progandy
reviewed
Nov 25, 2018
sway/config/bar.c
Outdated
| @@ -1,5 +1,5 @@ | |||
| #define _POSIX_C_SOURCE 200809L | |||
| #define _XOPEN_SOURCE 700 | |||
| #define _POSIX_C_SOURCE 200809L | |||
There was a problem hiding this comment.
_POSIX_C_SOURCE is defined twice here.
There was a problem hiding this comment.
Good catch. Since it's defined twice with the same value the compiler didn't complain. Fixed!
And make sure we don't define both in the same source file.
emersion
force-pushed
the
remove-xopen-source
branch
from
db714d9
to
3a310f9
Compare
RyanDwyer
approved these changes
Nov 26, 2018
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And make sure we don't define both in the same source file.