Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve mouse button parsing: seat cursor buttons #3343

Merged
merged 1 commit into from
Jan 14, 2019

Conversation

RedSoxFan
Copy link
Member

@RedSoxFan RedSoxFan commented Dec 28, 2018

DO NOT MERGE UNTIL AFTER #3341

This is the third in a series of follow-up PRs for #3313.

This modifies seat_cmd_cursor to utilize get_mouse_button when
parsing mouse buttons for the press and release operations. All x11
buttons, button event names, and button event codes are supported.
For x11 axis buttons, dispatch_cursor_axis is used instead of
dispatch_cursor_button. However the press/release state is ignored
and the either axis event is processed. This also removes support for
left and right in favor of BTN_LEFT and BTN_RIGHT.

Note: #3342 has a fix for a typo in get_mouse_button that prevents the call to
get_mouse_bindcode so in order to test bindcodes, rebasing against that PR
is currently necessary

This modifies `seat_cmd_cursor` to utilize `get_mouse_button` when
parsing mouse buttons for the `press` and `release` operations. All x11
buttons, button event names, and button event codes are supported.
For x11 axis buttons, `dispatch_cursor_axis` is used instead of
`dispatch_cursor_button`. However the `press`/`release` state is ignored
and the either axis event is processed. This also removes support for
`left` and `right` in favor of `BTN_LEFT` and `BTN_RIGHT`.
@RedSoxFan RedSoxFan changed the title [DO NOT MERGE] Improve mouse button parsing: seat cursor buttons Improve mouse button parsing: seat cursor buttons Jan 10, 2019
@RedSoxFan
Copy link
Member Author

Rebased and ready for review

@ddevault ddevault merged commit 9f9ef76 into swaywm:master Jan 14, 2019
@ddevault
Copy link
Contributor

Thanks!

@RedSoxFan RedSoxFan deleted the seat-cursor-buttons-improved branch January 14, 2019 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants