Improve mouse button parsing: seat cursor buttons #3343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This modifies `seat_cmd_cursor` to utilize `get_mouse_button` when parsing mouse buttons for the `press` and `release` operations. All x11 buttons, button event names, and button event codes are supported. For x11 axis buttons, `dispatch_cursor_axis` is used instead of `dispatch_cursor_button`. However the `press`/`release` state is ignored and the either axis event is processed. This also removes support for `left` and `right` in favor of `BTN_LEFT` and `BTN_RIGHT`.
RedSoxFan
force-pushed
the
seat-cursor-buttons-improved
branch
from
23067af
to
aa1c838
Compare
RedSoxFan
changed the title
|
Rebased and ready for review |
ddevault
approved these changes
Jan 14, 2019
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE UNTIL AFTER #3341This is the third in a series of follow-up PRs for #3313.
This modifies
seat_cmd_cursorto utilizeget_mouse_buttonwhenparsing mouse buttons for the
pressandreleaseoperations. All x11buttons, button event names, and button event codes are supported.
For x11 axis buttons,
dispatch_cursor_axisis used instead ofdispatch_cursor_button. However thepress/releasestate is ignoredand the either axis event is processed. This also removes support for
leftandrightin favor ofBTN_LEFTandBTN_RIGHT.Note: #3342 has a fix for a typo in
get_mouse_buttonthat prevents the call toget_mouse_bindcodeso in order to test bindcodes, rebasing against that PRis currently necessary