swaybar: fix rendering of border and background #3394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emersion
reviewed
Jan 9, 2019
swaybar/render.c
Outdated
| double x, double y, double width, double height) { | ||
| cairo_set_source_u32(cairo, color); | ||
| cairo_antialias_t antialias = cairo_get_antialias(cairo); |
There was a problem hiding this comment.
You can use cairo_save instead.
RedSoxFan
force-pushed
the
bar-block-render
branch
from
7151d8d
to
247ab7f
Compare
This fixes the rendering of borders and backgrounds for blocks. This also makes the following changes: * both borders and padding are scaled with the output * both lines and rectangles are rendered without an antialiasing to avoid bleeding outside the desired area
RedSoxFan
force-pushed
the
bar-block-render
branch
from
247ab7f
to
39873bc
Compare
emersion
approved these changes
Jan 10, 2019
|
Thanks! |
nmschulte
added a commit
to nmschulte/sway
that referenced
this pull request
Sep 15, 2021
introduced via swaywm#3287 -- https://github.com/swaywm/sway/pull/3287/files#diff-a1e918ce0bc71f4f7934767541319e724a51a34a5418ecdc286065e50921eda4L239 uncovered via swaywm#3394 -- https://github.com/swaywm/sway/pull/3394/files#diff-a1e918ce0bc71f4f7934767541319e724a51a34a5418ecdc286065e50921eda4R258
RagnarGrootKoerkamp
pushed a commit
to RagnarGrootKoerkamp/sway
that referenced
this pull request
Mar 29, 2022
introduced via swaywm#3287 -- https://github.com/swaywm/sway/pull/3287/files#diff-a1e918ce0bc71f4f7934767541319e724a51a34a5418ecdc286065e50921eda4L239 uncovered via swaywm#3394 -- https://github.com/swaywm/sway/pull/3394/files#diff-a1e918ce0bc71f4f7934767541319e724a51a34a5418ecdc286065e50921eda4R258
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #3329
This fixes the rendering of borders and backgrounds for blocks. This
also makes the following changes:
avoid bleeding outside the desired area
Follow-up points for the completion of #3329: