Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace broken debuglog command with log_level command. #3695

Closed
wants to merge 1 commit into from

Conversation

ggreer
Copy link
Contributor

@ggreer ggreer commented Feb 15, 2019

The debuglog command mentioned in the manpage wasn't hooked up at all. This patch replaces it with a log_level command that directly sets the log verbosity.

@ddevault
Copy link
Contributor

I'd rather just remove this entirely to be honest.

@ggreer
Copy link
Contributor Author

ggreer commented Feb 16, 2019

I think it's pretty handy to be able to set the log level in the config instead of tweaking how sway is started. I ended up making this change because someone on IRC recommended running swaymsg debuglog on to get more logging out of a sway that was in a buggy state. It turns out that despite being in the manpage, that's not a command that works.

Ideally, I'd also like to change the command line args to use a --log_level instead of -V and -d, but that seems like a whole 'nother can of worms. Long term, it'd be neat if config, swaymsg commands, and command line arguments were all unified in their names and behavior.

@ddevault
Copy link
Contributor

You generally don't get useful logs after the bugs have started. A partial debug log isn't very useful. I'm still in favor of removing this entirely.

@emersion
Copy link
Member

Yeah, +1 for removing this.

@ddevault ddevault closed this in cd10e75 Feb 17, 2019
ddevault added a commit that referenced this pull request Feb 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants