Fix layout calculations #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This brings consistency into the algorithm (instead of resetting and then fetching again).
| @@ -2,7 +2,7 @@ cmake_minimum_required(VERSION 3.1.0) | |||
|
|
|||
| project(sway C) | |||
|
|
|||
| set(CMAKE_C_FLAGS "-g") | |||
| set(CMAKE_C_FLAGS "-g -lm") | |||
There was a problem hiding this comment.
This is required by math.h, if this is not the right way to do this let me know.
There was a problem hiding this comment.
I think target_link_libraries is the preferred way to link stuff. And since this is only required by sway this could be moved to sway/CMakeLists.txt.
There was a problem hiding this comment.
Correct, use target_link_libraries in the sway subproject.
If the width or height of a container can't be evenly distributed to its children, then the layout algorithm still thought it got it right (due to using decimals) which caused a gap of one or more pixels for some window arrangements. This is fixed by this patch by first rounding off the width and height (so that decimals are never introduced) and then adjusting the last view in a container to fill the remaining pixels (which now is counted correctly due to the decimals being removed). Also, due to the way gaps are implemented, an odd sized gap can never be aligned properly, so just adjust to closest even number.
Previous output was confusing.
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the width or height of a container can't be evenly distributed to its
children, then the layout algorithm still thought it got it right (due
to using decimals) which caused a gap of one or more pixels for some
window arrangements.
This is fixed (by the second patch) by first rounding off the width and height
(so that decimals are never introduced) and then adjusting the last
view in a container to fill the remaining pixels (which now is counted
correctly due to the decimals being removed).
Also, due to the way gaps are implemented, an odd sized gap can never be
aligned properly, so just adjust to closest even number.
Fixes #392 .
First patch is a "minor refactoring" of the layout algorithm. Third patch adjusts some debug output that was annoying me.