Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sway spawns empty container upon entering fullscreen in qutebrowser #6202

Closed
lokesh-krishna opened this issue Apr 18, 2021 · 6 comments · Fixed by #6207
Closed

Sway spawns empty container upon entering fullscreen in qutebrowser #6202

lokesh-krishna opened this issue Apr 18, 2021 · 6 comments · Fixed by #6207
Labels
bug Not working as intended layout

Comments

@lokesh-krishna
Copy link

  • Sway Version: 1.6

  • Debug Log:
    sway.log

  • Configuration File:
    Can reproduce with default config

  • Description:

    • Launch qutebrowser (2.2.0) and use an in-tab full screen button to enter fullscreen while in tabbed mode
    • Exit full screen
    • Sway shifts back to tiled mode and there is now an empty container
    • Repeating the process keeps generating empty containers
@lokesh-krishna lokesh-krishna added the bug Not working as intended label Apr 18, 2021
@vilhalmer
Copy link
Contributor

It appears the parent container of qutebrowser is what actually gets fullscreened, as there is a container border visible in fullscreen.

@Xyene Xyene added the layout label Apr 18, 2021
@rpigott
Copy link
Member

rpigott commented Apr 18, 2021

Hmm I think this was also reported in #6116.

@rpigott
Copy link
Member

rpigott commented Apr 18, 2021

@lokesh-krishna Can you test #6207?

@lokesh-krishna
Copy link
Author

Um, I dunno how to do that. Would I be building it and then installing it over my present installation?

@rpigott
Copy link
Member

rpigott commented Apr 21, 2021

The readme has instructions on compiling from source, and to grab the PR you can git fetch origin pull/6207/head:fix && git checkout fix. You can just run the new sway binary from the build directory after ninja -C build/, no need to install it.

Anyway you don't have to I guess, it just expedites things a bit.

@budsterblue
Copy link

@rpigott I've been having the same issue with qutebrowser. I applied the PR as a patch to the sway-git AUR package (double checked to make sure it actually applied), and after some testing, it seems like the PR solves this issue for me. It's been incredibly annoying over the past few days, so thanks so much for the fix, and I hope it gets merged soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Not working as intended layout
Development

Successfully merging a pull request may close this issue.

5 participants