Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

input: enable user xkb configs with cap_sys_nice #7326

Merged
merged 1 commit into from
Jan 11, 2023

Conversation

rpigott
Copy link
Member

@rpigott rpigott commented Dec 15, 2022

replaces: #7311
fixes: #7229

This version uses a new xkb context flag to avoid secure_getenv in xkbcommon. We don't support suid operation so right now this flag is used unconditionally.

depends on: xkbcommon/libxkbcommon#312 (merged)

@rpigott rpigott mentioned this pull request Dec 15, 2022
@rpigott rpigott marked this pull request as draft December 15, 2022 09:02
triallax added a commit to triallax/void-packages that referenced this pull request Dec 30, 2022
Setting these capabilities on the Sway binary breaks loading custom
keymaps in user directories.

Relevant:
- swaywm/sway#7326 (this commit can be reverted
  when this PR is merged in a future Sway release)
- xkbcommon/libxkbcommon#312
@triallax
Copy link

triallax commented Jan 5, 2023

Just wondering, any reason this PR is still a draft? I would like to include this patch in Void Linux (void-linux/void-packages#41358), but I want to confirm that there isn't some flaw first.

(libxkbcommon 1.5.0 is out with xkbcommon/libxkbcommon#312 merged by the way)

@rpigott
Copy link
Member Author

rpigott commented Jan 5, 2023

Was just a draft until libxkbcommon released; I didn't notice the release had been made.

@rpigott rpigott marked this pull request as ready for review January 5, 2023 16:12
@rpigott
Copy link
Member Author

rpigott commented Jan 11, 2023

Seems like all the CI platforms have this release now, so it should be good to go.

Copy link
Member

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Allow specifying xkb include path
3 participants