-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
input: enable user xkb configs with cap_sys_nice #7326
Conversation
Setting these capabilities on the Sway binary breaks loading custom keymaps in user directories. Relevant: - swaywm/sway#7326 (this commit can be reverted when this PR is merged in a future Sway release) - xkbcommon/libxkbcommon#312
Just wondering, any reason this PR is still a draft? I would like to include this patch in Void Linux (void-linux/void-packages#41358), but I want to confirm that there isn't some flaw first. (libxkbcommon 1.5.0 is out with xkbcommon/libxkbcommon#312 merged by the way) |
Was just a draft until libxkbcommon released; I didn't notice the release had been made. |
Seems like all the CI platforms have this release now, so it should be good to go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
replaces: #7311
fixes: #7229
This version uses a new xkb context flag to avoid secure_getenv in xkbcommon. We don't support suid operation so right now this flag is used unconditionally.
depends on: xkbcommon/libxkbcommon#312 (merged)