Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

context: add XKB_CONTEXT_NO_SECURE_GETENV flag #312

Merged
merged 3 commits into from
Dec 16, 2022

Conversation

rpigott
Copy link
Contributor

@rpigott rpigott commented Dec 15, 2022

This flag is useful for clients that may have relatively benign capabilities set, like CAP_SYS_NICE, that also want to use the xkb configuration from the environment and user configs in XDG_CONFIG_HOME.

Fixes #308

This flag is useful for clients that may have relatively benign capabilities
set, like CAP_SYS_NICE, that also want to use the xkb configuration from the
environment and user configs in XDG_CONFIG_HOME.
@rpigott rpigott marked this pull request as ready for review December 15, 2022 02:27
Signed-off-by: Ran Benita <ran@unusedvar.com>
Signed-off-by: Ran Benita <ran@unusedvar.com>
@bluetech
Copy link
Member

Thanks. I made some edits and verified that it works as intended, so it's good to go.

@bluetech bluetech merged commit b4e81ca into xkbcommon:master Dec 16, 2022
@rpigott rpigott deleted the unsecuregetenv branch December 16, 2022 16:49
triallax added a commit to triallax/void-packages that referenced this pull request Dec 30, 2022
Setting these capabilities on the Sway binary breaks loading custom
keymaps in user directories.

Relevant:
- swaywm/sway#7326 (this commit can be reverted
  when this PR is merged in a future Sway release)
- xkbcommon/libxkbcommon#312
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make a XKB_CONTEXT_YES_DEFAULT_INCLUDES flag?
2 participants