Skip to content
This repository has been archived by the owner on Nov 1, 2021. It is now read-only.

Presentation feedback API doesn't identify the frame submission #1917

Closed
emersion opened this issue Nov 16, 2019 · 0 comments · Fixed by #1919
Closed

Presentation feedback API doesn't identify the frame submission #1917

emersion opened this issue Nov 16, 2019 · 0 comments · Fixed by #1919
Labels
bug output

Comments

@emersion
Copy link
Member

emersion commented Nov 16, 2019 •
edited

The presentation feedback API in wlr_output doesn't let backends specify for which frame submission the event is. So presentation feedback doesn't work properly if the delay is greater than one frame.

In practice, the DRM backend guarantees that the delay will be < 1 frame. However that's not the case for other backends.

We should add a way to track frame submissions (with a sequence number? with an object?). We already have output->commit_seq, we can probably re-use this for presentation feedback.
@emersion emersion mentioned this issue Nov 16, 2019
Merged
emersion added a commit to emersion/wlroots that referenced this issue Nov 16, 2019
@emersion
output: add wlr_output_event_present.commit_seq
5666b85 
This is set to the value of wlr_output.commit_seq when the frame has
been submitted. This allows tracking presentation with more then 1 full
frame of latency.

References: swaywm#1917
@emersion emersion mentioned this issue Nov 16, 2019
Merged
emersion added a commit that referenced this issue Nov 16, 2019
@emersion
output: add wlr_output_event_present.commit_seq
6c649ba 
This is set to the value of wlr_output.commit_seq when the frame has
been submitted. This allows tracking presentation with more then 1 full
frame of latency.

References: #1917
@emersion emersion mentioned this issue Nov 16, 2019
Merged
aiqs4 pushed a commit to aiqs4/wlroots that referenced this issue Dec 19, 2019
@emersion @aiqs4
output: add wlr_output_event_present.commit_seq
5a97ab1 
This is set to the value of wlr_output.commit_seq when the frame has
been submitted. This allows tracking presentation with more then 1 full
frame of latency.

References: swaywm#1917
aiqs4 pushed a commit to aiqs4/wlroots that referenced this issue Dec 19, 2019
@emersion @aiqs4
output: add wlr_output_event_present.commit_seq
fec046d 
This is set to the value of wlr_output.commit_seq when the frame has
been submitted. This allows tracking presentation with more then 1 full
frame of latency.

References: swaywm#1917
aiqs4 pushed a commit to aiqs4/wlroots that referenced this issue Dec 19, 2019
@emersion @aiqs4
output: add wlr_output_event_present.commit_seq
a14fa91 
This is set to the value of wlr_output.commit_seq when the frame has
been submitted. This allows tracking presentation with more then 1 full
frame of latency.

References: swaywm#1917
aiqs4 pushed a commit to aiqs4/wlroots that referenced this issue Dec 19, 2019
@emersion @aiqs4
output: add wlr_output_event_present.commit_seq
477189d 
This is set to the value of wlr_output.commit_seq when the frame has
been submitted. This allows tracking presentation with more then 1 full
frame of latency.

References: swaywm#1917
aiqs4 pushed a commit to aiqs4/wlroots that referenced this issue Dec 19, 2019
@emersion @aiqs4
output: add wlr_output_event_present.commit_seq
be82711 
This is set to the value of wlr_output.commit_seq when the frame has
been submitted. This allows tracking presentation with more then 1 full
frame of latency.

References: swaywm#1917
filips pushed a commit to filips/wlroots that referenced this issue Mar 15, 2020
@emersion @filips
output: add wlr_output_event_present.commit_seq
bdae3cf 
This is set to the value of wlr_output.commit_seq when the frame has
been submitted. This allows tracking presentation with more then 1 full
frame of latency.

References: swaywm#1917
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug output
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve presentation-time API emersion/wlroots
1 participant
@emersion