This repository has been archived by the owner on Nov 1, 2021. It is now read-only.
Improve presentation-time API #1919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows listeners to read the commit sequence number.
emersion
force-pushed
the
improve-presentation-tracking
branch
from
83be692
to
55ca0fe
Compare
Backends not supporting presentation feedback call wlr_output_send_present with a NULL event in their commit handler. Since the commit hasn't been applied yet, commit_seq still has its old value. We need to increment it. An alternative would be to move commit_seq in wlr_output_state. This would allow to have a pending and a current commit_seq. wlr_output_send_present could take the pending commit_seq when called with a NULL event.
emersion
force-pushed
the
improve-presentation-tracking
branch
from
55ca0fe
to
6030f30
Compare
YaLTeR
reviewed
Nov 17, 2019
The wlr_presentation_feedback struct now tracks presentation feedback for multiple resources (but still a single surface content update). This allows the compositor to properly send presentation events even when there is more than one frame of latency or when it references a surface's buffer.
Most of the time, compositors just display the surface's current buffer on an output. Add an helper to make it easy to support presentation-time in this case.
emersion
force-pushed
the
improve-presentation-tracking
branch
from
6030f30
to
34b3526
Compare
ddevault
approved these changes
Nov 21, 2019
|
Thanks! |
g7
pushed a commit
to droidian/phoc
that referenced
this pull request
Mar 19, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The wlr_presentation_feedback struct now tracks presentation feedback
for multiple resources (but still a single surface content update). This
allows the compositor to properly send presentation events even when
there is more than one frame of latency or when it references a
surface's buffer.
Most of the time, compositors just display the surface's current buffer
on an output. Add an helper to make it easy to support presentation-time
in this case.
References: swaywm/sway#4572
Closes: #1917
cc @YaLTeR
Breaking change: instead of calling
wlr_presentation_surface_sampledat render time andwlr_presentation_send_surface_presentedat presentation time, most compositors now just need to callwlr_presentation_surface_sampled_on_outputat render time. Compositors that callwlr_buffer_refneed to callwlr_presentation_surface_sampledwhen they ref the buffer,wlr_presentation_feedback_send_presentedwhen this buffer has been presented for the first time and thenwlr_presentation_feedback_destroy.Sway PR: swaywm/sway#4731