This repository has been archived by the owner on Nov 1, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 343
render: better integrate bind_buffer with begin/end #2618
Comments
emersion
added a commit
to emersion/wlroots
that referenced
this issue
Jan 14, 2021
Instead of requiring callers to manually make the EGL context current before binding a buffer and unsetting it after unbinding a buffer, do it inside wlr_renderer_bind_buffer. This hides renderer-specific implementation details inside the wlr_renderer interface. Non-GLES2 renderers may not use EGL. This removes almost all EGL dependencies from the backends, the only remaining one is wlr_renderer_autocreate args. References: swaywm#2618 References: swaywm#2615 (comment)
emersion
added a commit
to emersion/wlroots
that referenced
this issue
Jan 16, 2021
Instead of requiring callers to manually make the EGL context current before binding a buffer and unsetting it after unbinding a buffer, do it inside wlr_renderer_bind_buffer. This hides renderer-specific implementation details inside the wlr_renderer interface. Non-GLES2 renderers may not use EGL. This removes almost all EGL dependencies from the backends, the only remaining one is wlr_renderer_autocreate args. References: swaywm#2618 References: swaywm#2615 (comment)
emersion
added a commit
to emersion/wlroots
that referenced
this issue
Jan 16, 2021
Instead of requiring callers to manually make the EGL context current before binding a buffer and unsetting it after unbinding a buffer, do it inside wlr_renderer_bind_buffer. This hides renderer-specific implementation details inside the wlr_renderer interface. Non-GLES2 renderers may not use EGL. This removes all EGL dependencies from the backends. References: swaywm#2618 References: swaywm#2615 (comment)
emersion
added a commit
that referenced
this issue
Jan 16, 2021
Instead of requiring callers to manually make the EGL context current before binding a buffer and unsetting it after unbinding a buffer, do it inside wlr_renderer_bind_buffer. This hides renderer-specific implementation details inside the wlr_renderer interface. Non-GLES2 renderers may not use EGL. This removes all EGL dependencies from the backends. References: #2618 References: #2615 (comment)
emersion
added a commit
to emersion/wlroots
that referenced
this issue
Jun 1, 2021
This allows compositors to choose a wlr_buffer to render to. This is a less awkward interface than having to call bind_buffer() before and after begin() and end(). Closes: swaywm#2618
emersion
added a commit
to emersion/wlroots
that referenced
this issue
Jun 1, 2021
This allows compositors to choose a wlr_buffer to render to. This is a less awkward interface than having to call bind_buffer() before and after begin() and end(). Closes: swaywm#2618
bl4ckb0ne
pushed a commit
that referenced
this issue
Jun 1, 2021
This allows compositors to choose a wlr_buffer to render to. This is a less awkward interface than having to call bind_buffer() before and after begin() and end(). Closes: #2618
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Right now, one needs to do the following to render:
Once #2615 (comment) is done, this could be simplified to:
I'm still not very happy with the API, something like this would be better:
However this would be a breaking change, because compositors call
wlr_renderer_begin
. Also need to figure out if/how compositors should acquire the buffer.The text was updated successfully, but these errors were encountered: