Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize arguments #46

Closed
kdy1 opened this issue Nov 10, 2018 · 3 comments · Fixed by #49
Closed

Optimize arguments #46

kdy1 opened this issue Nov 10, 2018 · 3 comments · Fixed by #49

Comments

@kdy1
Copy link
Member

kdy1 commented Nov 10, 2018

use(8 + 8) should be use(16)
But I don't know why it is not optimized.

@mamaar
Copy link

mamaar commented Nov 11, 2018

The problem is that the span still points to the original source after simplifying, so the code generator outputs that.

The match expression here could probably be replaced with just the None case?

match get_text_of_node(&self.cm, num, false) {

@kdy1
Copy link
Member Author

kdy1 commented Nov 11, 2018

@mamaar Fixed in #49. Also, modified emitter a bit to avoid deoptimization.

@kdy1 kdy1 closed this as completed in #49 Nov 14, 2018
@swc-bot
Copy link
Collaborator

swc-bot commented Oct 31, 2022

This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@swc-project swc-project locked as resolved and limited conversation to collaborators Oct 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging a pull request may close this issue.

3 participants