Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve comment testing story in Wasm plugins #9149

Closed
2 tasks
kdy1 opened this issue Jul 5, 2024 · 1 comment · Fixed by #9150
Closed
2 tasks

Improve comment testing story in Wasm plugins #9149

kdy1 opened this issue Jul 5, 2024 · 1 comment · Fixed by #9150
Assignees
@kdy1
Labels
enhancement
Milestone
v1.6.12

Comments

@kdy1
Copy link
Member

kdy1 commented Jul 5, 2024

Describe the feature

  • PluginProxyComment should use the comments of Tester while running test_fixture.
  • test_fixture should dump all comments left on exit

Babel plugin or link to the feature description

No response

Additional context

No response
@kdy1 kdy1 added this to the Planned milestone Jul 5, 2024
@kdy1 kdy1 self-assigned this Jul 5, 2024
@jantimon jantimon mentioned this issue Jul 5, 2024
Closed
@kdy1 kdy1 mentioned this issue Jul 5, 2024
Merged
@kdy1 kdy1 closed this as completed in #9150 Jul 6, 2024
@kdy1 kdy1 closed this as completed in 3638e97 Jul 6, 2024
@kdy1 kdy1 modified the milestones: Planned, v1.6.10 Jul 6, 2024
@swc-bot
Copy link
Collaborator

swc-bot commented Aug 5, 2024

This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@swc-project swc-project locked as resolved and limited conversation to collaborators Aug 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kdy1 kdy1

Labels
enhancement
Milestone
v1.6.12
Development

Successfully merging a pull request may close this issue.

feat(es/testing): Improve comment testing story kdy1/swc
2 participants
@kdy1 @swc-bot