perf(es/ast): Properly box variants #9158
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This didn't have noticeable positive effect on the performance of the parser |
kdy1
force-pushed
the
ast-perf
branch
3 times, most recently
from
bd77967
to
435dfb7
Compare
**Description:** The identifier in the `prop` field of `MemberExpr` does not need information like `optional` or `ctxt`.
**Description:** This PR changes the AST node construction code to use `.into()` or `::from()` to make changing the boxed-ness of the AST node easier. I used `ast-grep` to make large changes across codebase.
kdy1
force-pushed
the
ast-perf
branch
2 times, most recently
from
1600b50
to
8c045fb
Compare
…#9201) **Description:** This PR will help modifying boxedness of AST nodes.
|
I'll try a different approach |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Stmt::Directive.