Skip to content
This repository has been archived by the owner on Jan 3, 2018. It is now read-only.

change in the html to fix layout issue #553

Merged
merged 3 commits into from
Aug 21, 2014

Conversation

twitwi
Copy link
Contributor

@twitwi twitwi commented Jul 20, 2014

(tested using firefox's responsive design view)

for swcarpentry/DEPRECATED-bc#601

@rgaiacs
Copy link
Contributor

rgaiacs commented Jul 21, 2014

@twitwi Thanks for this.

What about

<div class="row-fluid">
<div class="span6">
<h2>Version 5</h2>
...
<li><a href="v5/intro.html">Introduction</a></li>
...
</div>
<div class="span6">
<h2>Version 4</h2>
...
<li><a href="v4/vc/index.html">Using Subversion</a></li>
...
</div>
</div>

I mean you also move the table of contents of v4.

@twitwi
Copy link
Contributor Author

twitwi commented Jul 21, 2014

I had tried but couldn't get the two-column TOC of version 4 to display properly: I always get something that is either too packed or not side by side.

@rgaiacs
Copy link
Contributor

rgaiacs commented Jul 21, 2014

@twitwi Please take a look at twitwi#1.

@rgaiacs
Copy link
Contributor

rgaiacs commented Jul 21, 2014

@pipitone Could you check this PR and merge it as part of the sprint tomorrow?

@rgaiacs
Copy link
Contributor

rgaiacs commented Aug 21, 2014

@grayclhn Could you check this PR?

@gvwilson Do you have time to review and merge this? I didn't merge it because it has some lines wrote by me.

@gvwilson
Copy link
Contributor

@acabunoc can you please check this one?

@abbycabs
Copy link
Contributor

Yup, I'll do this today

@abbycabs abbycabs self-assigned this Aug 21, 2014
@abbycabs
Copy link
Contributor

Looks great to me! Merging.

abbycabs added a commit that referenced this pull request Aug 21, 2014
 change in the html to fix layout issue
@abbycabs abbycabs merged commit 0a4ef5f into swcarpentry:master Aug 21, 2014
@chendaniely
Copy link
Contributor

does the site automatically incorporate changes when it gets merged? I can still replicate the issue on my desktop by shirking the width of the browser window

@abbycabs
Copy link
Contributor

@chendaniely - confirmed. Not sure what the build process is here, but it's fixed for me locally build from master. So... hoping the site doesn't automatically incorporate changes.

@gvwilson
Copy link
Contributor

Builds are triggered manually - I'm doing one now.

@chendaniely
Copy link
Contributor

confirmed fixed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants