Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hooks fail when using toml array syntax for multi-commands in rusty-hook.toml #151

Closed
4 tasks
simon-amadeus opened this issue Mar 23, 2021 · 2 comments
Closed
4 tasks

Comments

@simon-amadeus
Copy link

Environment Details

  • Operating System
    • Linux
    • [ x] Mac
    • Windows
  • Rust Version: 1.52.0
  • Rust Release Channel
    • Stable
    • [x ] Nightly
    • Beta
  • Cargo Version: 1.52.0-nightly (572e20153 2021-02-24)
  • rusty-hook Version: 0.11.2

Description

Whenever I use the multi-command syntax using toml arrays, rusty-hook fails with the following output:

$git commit
Invalid rusty-hook config file
Configured hook command failed
pre-commit hook rejected

This happens regardless, of the trigger type (pre-commit, pre-push), and the executed commands.
As a workaround I am now using && to chain them into a single command.

@calebcartwright
Copy link
Member

Hi thanks for using the tool and reaching out, but going to close this. Support for array syntax in the config file was added in the unreleased v0.12.0 which is why it's not available for you in v0.11.2 (which is the latest released & supported version).

#137 covers updating the documentation, and hopefully once #143 lands that will be a bit more clear.

@webbertakken
Copy link

@calebcartwright

Hi thanks for using the tool and reaching out, but going to close this. Support for array syntax in the config file was added in the unreleased v0.12.0 which is why it's not available for you in v0.11.2 (which is the latest released & supported version).

#137 covers updating the documentation, and hopefully once #143 lands that will be a bit more clear.

Any chance you could release v0.12.0?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants