Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add disable_spellcheck() and clear_spellcheck_markers() methods, suggest_word_for_misspelled #3

Merged
merged 3 commits into from
Dec 10, 2018

Conversation

blurymind
Copy link
Contributor

also set to spellcheck only when required instead of each half second - doing that should make it drain less battery - especially with alot of text

… set to spellcheck only when required instead of each half second
@blurymind blurymind changed the title add disable_spellcheck() and clear_spellcheck_markers() methods, add disable_spellcheck() and clear_spellcheck_markers() methods, suggest_word_for_misspelled Dec 10, 2018
Copy link
Owner

@swenson swenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for the contribution!

@swenson swenson merged commit e846d2f into swenson:master Dec 10, 2018
@blurymind
Copy link
Contributor Author

hey no problem :)
I am already using it in this pull:
InfiniteAmmoInc/Yarn#80

@swenson
Copy link
Owner

swenson commented Dec 10, 2018

I'm glad you're finding this useful!

@blurymind
Copy link
Contributor Author

blurymind commented Dec 10, 2018

Its now used in yarn editor to mark misspelled words. For some reason the feature wasnt fully implemented, so I picked it up and got it to work.
I needed to add the method to disable it in order to make it optional to the user.
The last method I added is now used by the context menu - to suggest possible corrections of a selected misspelled word

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants