Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve stimulus waveform synthesis #69

Closed
swharden opened this issue Dec 14, 2018 · 1 comment
Closed

Improve stimulus waveform synthesis #69

swharden opened this issue Dec 14, 2018 · 1 comment
Assignees

Comments

@swharden
Copy link
Owner

swharden commented Dec 14, 2018

ABF1 files and ABF 2.9 files aren't generating proper stimulus waveforms (abf.sweepC) at present. The stimulus module is the messiest part of pyABF, and would benefit from a clean re-code.

In the process of recreating this module, ensure ABF1 and ABF2.9 files (created with pCLAMP 11) are supported.

@swharden swharden self-assigned this Dec 14, 2018
@swharden swharden changed the title ABF1 stimulus waveforms Improve stimulus waveform synthesis Dec 14, 2018
@swharden
Copy link
Owner Author

entirely re-wrote the stimulus module, breaking it into two:

Many ABFs which previously produced empty abf.sweepC arrays are now populated. This is evidenced by the fact virtually every ABF on the data page now has a graphed stimulus waveform. Further, many previous stimuli were erroneous (mostly ones with level deltas which did not return to holding levels between sweeps):

I'll close this issue when these changes are pushed to pypi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant