Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor epoch synthesis module #35

Closed
swharden opened this issue Sep 1, 2018 · 1 comment
Closed

refactor epoch synthesis module #35

swharden opened this issue Sep 1, 2018 · 1 comment

Comments

@swharden
Copy link
Owner

swharden commented Sep 1, 2018

abf.epochPoints and abf.epochValues are now simple to access. If abf.epochTypes is added, epoch waveform synthesis can be dramatically simplified (by simply reading these 3 lists). stimulus.py could be greatly simplified by refactoring to this model.
@swharden
Copy link
Owner Author

swharden commented Dec 3, 2018

There are larger refactor issues at hand, but this is certainly a big one. The stimulus module is messy and confusing as heck. All this will be tackled in pyABF 2.1 (which seeks only to improve the side modules without touching the ABF class).

@swharden swharden closed this as completed Dec 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@swharden