Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New API stable enough and new release #51

Closed
t-b opened this issue Nov 13, 2018 · 3 comments
Closed

New API stable enough and new release #51

t-b opened this issue Nov 13, 2018 · 3 comments

Comments

@t-b
Copy link
Contributor

t-b commented Nov 13, 2018

I'm using pyABF in https://github.com/AllenInstitute/ipfx/blob/master/ipfx/x_to_nwb/ABFConverter.py in version 2.0.18.

Is the new API stable enough so that upgrading to it now makes sense?
If yes, could you create a pypi release before?

@swharden
Copy link
Owner

I'll review it this evening and update this ticket when a release is made! I've been using it quite a lot for the last few months and it is indeed very stable.

@swharden
Copy link
Owner

I just issued a release and updated PyPi. I have very high confidence in the stability of this release (relatively little has changed since the last release):
https://github.com/swharden/pyABF/releases/tag/2.0.23

@t-b
Copy link
Contributor Author

t-b commented Nov 16, 2018

@swharden Thanks for the quick release. I've ported my application to the new API and my tests showed that it works. I've only spotted that the custom protocol location is not available anymore, I've added that in #55. And some code cleanup in #54.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants