This repository has been archived by the owner on Apr 13, 2021. It is now read-only.
Observations output below CN0 threshold #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test PASSed. |
|
HITL indicates a large (but not total) drop in fixed->float transitions. I'm happy to put this up for review now. |
|
lgtm |
cbeighley
added a commit
that referenced
this pull request
May 27, 2015
Observations output below CN0 threshold
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why: We have observed observations being generated with CN0 values below the tracking threshold specified in the firmware. These observations also frequently contain cycle slips (as may be expected given the low SNR). It is hypothesized that these observations are one of the main causes of fixed -> float transitions.
How: Right now we don't directly test the SNR when checking if we should filter out an observation, we only check the hysteresis counter. I think that what we are seeing is somehow the
manage_track()thread is not getting called in time to update and hence we are outputting bad measurements. The easiest fix is to just directly check the SNR each time in addition to looking at the hysteresis counter.Testing: HITL test has been created to check for this effect, see
TrackingTest_observations_obs_cn0_below_thresandTrackingTest_observations_obs_cn0_min.Hopefully helps with #81.