Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ATC information ("controller ATIS") always pulls VATSIM data [GERMAN] #280

Closed
FlyingFoxVATSIM opened this issue Apr 23, 2024 · 2 comments · Fixed by #281
Closed

ATC information ("controller ATIS") always pulls VATSIM data [GERMAN] #280

FlyingFoxVATSIM opened this issue Apr 23, 2024 · 2 comments · Fixed by #281
Assignees
Labels
bug Something isn't working good first issue Good for newcomers
Milestone

Comments

@FlyingFoxVATSIM
Copy link

Gestern beim FSeV Gruppenflug: nach Hamburg, EDDH: Alle User der Alpha ....142 Version sahen im Text die EDDH. ATIS von VATSIM und nicht den Text vom FSC EDDH Tower Controller. Wir haben dann die neuste Beta genommen und dort wurde der FSC ATIS Text gezeigt. Wieder zurück auf die Alpha.....142 wurde wieder der VATSIM EDDH ATIS Text gezeigt. In der Alpha scheint irgendwie eine Bridge zum Vatsim Server zu sein ( wenn die Tower Frequenzen identisch sind) ?

Hamburg_mit_Vatsim_ATIS

@ltoenning
Copy link
Contributor

Likely related to this change:
9cdd624#diff-a5c30df061ab3a930eb8fa8cafa47926a751092e3fba9eacf890c5bf27c543a8L177
With this change (and commit) we always start reading the VATSIM datafile for simplicity.

The ATIS is initially always populated from the datafile to avoid delays until getting the real ATIS via FSD:

// new station, init with data from data file
CAtcStation station(sApp->getWebDataServices()->getAtcStationsForCallsign(callsign).frontOrDefault());

Previously, this worked fine because the WebDataServices just returned an empty list when not connected to VATSIM.

Proposed solution: The CAirspaceMonitor can check the ecosystem of the connected server. Hence a simple check can be included to avoid populating the station ATIS with VATSIM data when connected to non-VATSIM servers.

@ltoenning ltoenning added the bug Something isn't working label Apr 23, 2024
@ltoenning ltoenning added this to the Release 0.15 milestone Apr 23, 2024
@ltoenning ltoenning added the good first issue Good for newcomers label Apr 23, 2024
@ltoenning
Copy link
Contributor

Side note: For adding a new aircraft, something similar is already done 😄

if (this->getConnectedServer().getEcosystem() == CEcosystem::vatsim())
{
sApp->getWebDataServices()->updateWithVatsimDataFileData(newAircraft);
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants