Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MSFS native support #266
base: main
Are you sure you want to change the base?
MSFS native support #266
Changes from 23 commits
6a542d0
d5022c7
b05da07
752cb41
5ea081f
2592621
b1322b4
b81a3fd
478ff62
0d0867e
44d0f3f
4347288
809eae6
8b74530
7b5171d
33abf3a
0aef5c2
94e8033
bb6c2e6
6f0ceb1
4948ae0
a96090c
9e2b4c5
5908bdb
736813f
97aafba
db57d81
e01022d
f5f8519
34ea38f
b7cf85a
eb430f4
944e90a
bfd3b70
34b973e
819cf83
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More a general thing: should we rename MSFS internally to MSFS2020 or something similar? Otherwise it gets confusing because we already use "MsFlightSimulator" (which could also be abbreviated as MSFS) at other place. And how would we call it when MSFS 2024 will be released 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest MSFS20 and later MSFS24. Agreed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should MSFS 2020 also be added to the method on line 48 (
isCompiledWithMsFlightSimulatorSupport()
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, I'll upload it with the next PUSH