MSFS native support #266
MSFS native support #266
Conversation
|
|
src/blackconfig/buildconfig.h
Outdated
| @@ -38,6 +38,9 @@ namespace BlackConfig | |||
| //! with FG support? | |||
| static constexpr bool isCompiledWithFGSupport(); // defined in buildconfig_gen.inc.in | |||
|
|
|||
| //! with MSFS support? | |||
| static constexpr bool isCompiledWithMSFSSupport(); // defined in buildconfig_gen.inc.in | |||
There was a problem hiding this comment.
More a general thing: should we rename MSFS internally to MSFS2020 or something similar? Otherwise it gets confusing because we already use "MsFlightSimulator" (which could also be abbreviated as MSFS) at other place. And how would we call it when MSFS 2024 will be released 😉
There was a problem hiding this comment.
I suggest MSFS20 and later MSFS24. Agreed?
src/blackconfig/buildconfig.h
Outdated
| @@ -38,6 +38,9 @@ namespace BlackConfig | |||
| //! with FG support? | |||
| static constexpr bool isCompiledWithFGSupport(); // defined in buildconfig_gen.inc.in | |||
|
|
|||
| //! with MSFS support? | |||
| static constexpr bool isCompiledWithMSFSSupport(); // defined in buildconfig_gen.inc.in | |||
|
|
|||
| //! with FSUIPC support? | |||
| static constexpr bool isCompiledWithFsuipcSupport(); // defined in buildconfig_gen.inc.in | |||
|
|
|||
There was a problem hiding this comment.
Should MSFS 2020 also be added to the method on line 48 (isCompiledWithMsFlightSimulatorSupport()?
There was a problem hiding this comment.
yes, I'll upload it with the next PUSH
| //! Find the config files (fsx.cfg) | ||
| // C:/Users/Joe Doe/AppData/Roaming/Microsoft/FSX/fsx.cfg | ||
| static QStringList findFsxConfigFiles(); | ||
|
|
||
| // TODO TZ |
There was a problem hiding this comment.
Is this TODO still outstanding?
There was a problem hiding this comment.
I think this function doesn't do what it's supposed to do. That's why I want to watch it
| //! Get all the SimObjects paths from fsx.cfg | ||
| // SimObjectPaths.0=SimObjects\Airplanes | ||
| static QSet<QString> fsxSimObjectsPaths(const QStringList &fsxFiles, bool checked); | ||
|
|
||
| // TODO TZ |
There was a problem hiding this comment.
Is this TODO still outstanding?
There was a problem hiding this comment.
I think this function doesn't do what it's supposed to do. That's why I want to watch it
| //! Get all the SimObjects files from fsx.cfg | ||
| // SimObjectPaths.0=SimObjects\Airplanes | ||
| static QSet<QString> fsxSimObjectsPaths(const QString &fsxFile, bool checked); | ||
|
|
||
| // TODO TZ |
There was a problem hiding this comment.
Is this TODO still outstanding?
There was a problem hiding this comment.
I think this function doesn't do what it's supposed to do. That's why I want to watch it
| // todo msfs: MSFS specific model validation | ||
| // const CStatusMessageList specificTests2 = FsCommon::CFsCommonUtil::validateMSFSSimObjectsPath(models, validModels, invalidModels, ignoreEmpty, stopAtFailedFiles, wasStopped, simulatorDir); | ||
| // specificTests.push_back(specificTests2); |
There was a problem hiding this comment.
Open a GitHub issue for this, so it does not get lost.
Co-Authored-By: Roland Rossgotterer <roland.rossgotterer@gmail.com> Co-Authored-By: tzobler <tzobler@t-online.de>
ltoenning
force-pushed
the
msfs_retry
branch
from
819cf83
to
c5a31d4
Compare
All necessary fields in the GUI and mapping tool have been created (based on Roland's changes). Tested communication with datastore and no errors so far. "Saved settings" message added when saving distributor selection. Search for aircaft.cfg optimized for MSFS