Alias analysis cleanups #11

nadavrot · 2015-11-23T03:40:51Z

This pull request contains a bunch of cleanups to AliasAnalysis. Changes:

Removing the cache from AliasAnalysis.
Renaming getMemoryBehavior to computeMemoryBehavior.
Documenting stuff, and removing the default argument form a method.

@trentxintong @gottesmm @atrick

…mory location.

Document alias() and roll the mayAlias() family of methods into a single function.

ObserveRetains is not an obvious default and it does not make sense to have it as a default argument.

Move some comments from the definition to the decleration and tidy some of the comments.

getMemoryBehavior is also used by SILInstruction. This commit renames getMemoryBehavior to computeMemoryBehavior and cleans some of the code that touches it.

getMemoryBehavior is also used by SILInstruction. This commit renames getMemoryBehavior to computeMemoryBehavior and cleans some of the code that touches it. // I forgot to add this file in my previous commit.

The AliasAnalysis is unsafe. When we delete instructions we don't have a good mechanism for invalidating the cache and we don't want instructions to explicitly invalidate AliasAnalysis after every deletion of an instruction. Morever, the alias analysis cache _always_ misses. Removing the cache did not change the build time of the standard library at all.

Alias Analysis cleanups

nadavrot · 2015-11-23T06:24:12Z

The incremental bots picked up the change and are now green.

lattner · 2015-11-23T06:35:49Z

On Nov 22, 2015, at 10:24 PM, Nadav Rotem notifications@github.com wrote:

The incremental bots picked up the change and are now green.

Great, thanks Nadav. In the future, please prefer to do incremental development on master if possible. I realize that git encourages off-line accretion of large patch sets, but please resist the urge and push as frequently as possible.

-Chris

btw, I’m glad you survived :-)

nadavrot · 2015-11-23T15:21:16Z

@lattner The development did go into master. When you perform a pull-request on a rebased branch, git commits directly to master. I made sure to rebase my development branch to keep the history linear. Github shows a 'merge' commit in its user interface, but you can't see this merge from the command line. You can verify this by running "git log --graph". Our history is linear.

lattner · 2015-11-23T16:05:54Z

Ok, let me phrase it a different way: please do development on master instead of a branch, wherever possible. Dev branches work against the project goal of incremental development.

-Chris

On Nov 23, 2015, at 7:21 AM, Nadav Rotem notifications@github.com wrote:

@lattner The development *did( go into master. When you perform a pull-request on a rebased branch git commits directly to master. I made sure to rebase my development branch to keep the history linear. Github shows a 'merge' commit in its user interface, but you can't see this merge from the command line. You can verify this by running "git log --graph". Our history is linear.

—
Reply to this email directly or view it on GitHub.

tkremenek · 2015-11-23T18:21:03Z

I suspect some of this was motivated because 'master' was locked.

On Nov 23, 2015, at 8:05 AM, Chris Lattner notifications@github.com wrote:

Ok, let me phrase it a different way: please do development on master instead of a branch, wherever possible. Dev branches work against the project goal of incremental development.

-Chris

On Nov 23, 2015, at 7:21 AM, Nadav Rotem notifications@github.com wrote:

@lattner The development *did( go into master. When you perform a pull-request on a rebased branch git commits directly to master. I made sure to rebase my development branch to keep the history linear. Github shows a 'merge' commit in its user interface, but you can't see this merge from the command line. You can verify this by running "git log --graph". Our history is linear.

—
Reply to this email directly or view it on GitHub.

—
Reply to this email directly or view it on GitHub.

Add test case for crash triggered in `swift::ASTVisitor`. Current number of unresolved compiler crashers: 121 (5184 resolved) Assertion failure in [`lib/Sema/CSApply.cpp (line 2599)`](https://github.com/apple/swift/blob/master/lib/Sema/CSApply.cpp#L2599): ``` Assertion `conforms && "Type does not conform to protocol?"' failed. When executing: swift::Expr *<anonymous namespace>::ExprRewriter::visitArrayExpr(swift::ArrayExpr *) ``` Assertion context: ``` bool conforms = tc.conformsToProtocol(arrayTy, arrayProto, cs.DC, ConformanceCheckFlags::InExpression, &conformance); (void)conforms; assert(conforms && "Type does not conform to protocol?"); // Call the witness that builds the array literal. // FIXME: callWitness() may end up re-doing some work we already did // to convert the array literal elements to the element type. It would // be nicer to re-use them. ``` Stack trace: ``` #0 0x00000000031d10e8 llvm::sys::PrintStackTrace(llvm::raw_ostream&) (/path/to/swift/bin/swift+0x31d10e8) #1 0x00000000031d1936 SignalHandler(int) (/path/to/swift/bin/swift+0x31d1936) #2 0x00007f9d8070c330 __restore_rt (/lib/x86_64-linux-gnu/libpthread.so.0+0x10330) #3 0x00007f9d7eecac37 gsignal /build/eglibc-oGUzwX/eglibc-2.19/signal/../nptl/sysdeps/unix/sysv/linux/raise.c:56:0 #4 0x00007f9d7eece028 abort /build/eglibc-oGUzwX/eglibc-2.19/stdlib/abort.c:91:0 #5 0x00007f9d7eec3bf6 __assert_fail_base /build/eglibc-oGUzwX/eglibc-2.19/assert/assert.c:92:0 #6 0x00007f9d7eec3ca2 (/lib/x86_64-linux-gnu/libc.so.6+0x2fca2) #7 0x0000000000c3028a swift::ASTVisitor<(anonymous namespace)::ExprRewriter, swift::Expr*, void, void, void, void, void>::visit(swift::Expr*) (/path/to/swift/bin/swift+0xc3028a) #8 0x0000000000c230c0 (anonymous namespace)::ExprRewriter::walkToExprPost(swift::Expr*) (/path/to/swift/bin/swift+0xc230c0) #9 0x0000000000c34cf0 (anonymous namespace)::ExprWalker::walkToExprPost(swift::Expr*) (/path/to/swift/bin/swift+0xc34cf0) #10 0x0000000000d659d5 swift::Expr::walk(swift::ASTWalker&) (/path/to/swift/bin/swift+0xd659d5) #11 0x0000000000c1fb22 swift::constraints::ConstraintSystem::applySolution(swift::constraints::Solution&, swift::Expr*, swift::Type, bool, bool, bool) (/path/to/swift/bin/swift+0xc1fb22) #12 0x0000000000b8da04 swift::TypeChecker::typeCheckExpression(swift::Expr*&, swift::DeclContext*, swift::TypeLoc, swift::ContextualTypePurpose, swift::OptionSet<swift::TypeCheckExprFlags, unsigned int>, swift::ExprTypeCheckListener*, swift::constraints::ConstraintSystem*) (/path/to/swift/bin/swift+0xb8da04) #13 0x0000000000c44105 (anonymous namespace)::FailureDiagnosis::typeCheckChildIndependently(swift::Expr*, swift::Type, swift::ContextualTypePurpose, swift::OptionSet<TCCFlags, unsigned int>, swift::ExprTypeCheckListener*) (/path/to/swift/bin/swift+0xc44105) #14 0x0000000000c55393 (anonymous namespace)::FailureDiagnosis::typeCheckArgumentChildIndependently(swift::Expr*, swift::Type, (anonymous namespace)::CalleeCandidateInfo const&, swift::OptionSet<TCCFlags, unsigned int>) (/path/to/swift/bin/swift+0xc55393) #15 0x0000000000c5126b (anonymous namespace)::FailureDiagnosis::visitApplyExpr(swift::ApplyExpr*) (/path/to/swift/bin/swift+0xc5126b) #16 0x0000000000c4ce0f swift::ASTVisitor<(anonymous namespace)::FailureDiagnosis, bool, void, void, void, void, void>::visit(swift::Expr*) (/path/to/swift/bin/swift+0xc4ce0f) #17 0x0000000000c3cab6 swift::constraints::ConstraintSystem::diagnoseFailureForExpr(swift::Expr*) (/path/to/swift/bin/swift+0xc3cab6) #18 0x0000000000c43210 swift::constraints::ConstraintSystem::salvage(llvm::SmallVectorImpl<swift::constraints::Solution>&, swift::Expr*) (/path/to/swift/bin/swift+0xc43210) #19 0x0000000000b8aecf swift::TypeChecker::solveForExpression(swift::Expr*&, swift::DeclContext*, swift::Type, swift::FreeTypeVariableBinding, swift::ExprTypeCheckListener*, swift::constraints::ConstraintSystem&, llvm::SmallVectorImpl<swift::constraints::Solution>&, swift::OptionSet<swift::TypeCheckExprFlags, unsigned int>) (/path/to/swift/bin/swift+0xb8aecf) #20 0x0000000000b8d96e swift::TypeChecker::typeCheckExpression(swift::Expr*&, swift::DeclContext*, swift::TypeLoc, swift::ContextualTypePurpose, swift::OptionSet<swift::TypeCheckExprFlags, unsigned int>, swift::ExprTypeCheckListener*, swift::constraints::ConstraintSystem*) (/path/to/swift/bin/swift+0xb8d96e) #21 0x0000000000b913a7 swift::TypeChecker::typeCheckCondition(swift::Expr*&, swift::DeclContext*) (/path/to/swift/bin/swift+0xb913a7) #22 0x0000000000b91bba swift::TypeChecker::typeCheckExprPattern(swift::ExprPattern*, swift::DeclContext*, swift::Type) (/path/to/swift/bin/swift+0xb91bba) #23 0x0000000000bd4031 swift::TypeChecker::coercePatternToType(swift::Pattern*&, swift::DeclContext*, swift::Type, swift::OptionSet<swift::TypeResolutionFlags, unsigned int>, swift::GenericTypeResolver*, swift::TypeLoc) (/path/to/swift/bin/swift+0xbd4031) #24 0x0000000000bd38f4 swift::TypeChecker::coercePatternToType(swift::Pattern*&, swift::DeclContext*, swift::Type, swift::OptionSet<swift::TypeResolutionFlags, unsigned int>, swift::GenericTypeResolver*, swift::TypeLoc) (/path/to/swift/bin/swift+0xbd38f4) #25 0x0000000000b950bb swift::TypeChecker::typeCheckBinding(swift::Pattern*&, swift::Expr*&, swift::DeclContext*)::BindingListener::appliedSolution(swift::constraints::Solution&, swift::Expr*) (/path/to/swift/bin/swift+0xb950bb) #26 0x0000000000b8da9c swift::TypeChecker::typeCheckExpression(swift::Expr*&, swift::DeclContext*, swift::TypeLoc, swift::ContextualTypePurpose, swift::OptionSet<swift::TypeCheckExprFlags, unsigned int>, swift::ExprTypeCheckListener*, swift::constraints::ConstraintSystem*) (/path/to/swift/bin/swift+0xb8da9c) #27 0x0000000000b90b35 swift::TypeChecker::typeCheckBinding(swift::Pattern*&, swift::Expr*&, swift::DeclContext*) (/path/to/swift/bin/swift+0xb90b35) #28 0x0000000000b91535 swift::TypeChecker::typeCheckStmtCondition(llvm::MutableArrayRef<swift::StmtConditionElement>&, swift::DeclContext*, swift::Diag<>) (/path/to/swift/bin/swift+0xb91535) #29 0x0000000000c02771 swift::ASTVisitor<(anonymous namespace)::StmtChecker, void, swift::Stmt*, void, void, void, void>::visit(swift::Stmt*) (/path/to/swift/bin/swift+0xc02771) #30 0x0000000000c024cc swift::ASTVisitor<(anonymous namespace)::StmtChecker, void, swift::Stmt*, void, void, void, void>::visit(swift::Stmt*) (/path/to/swift/bin/swift+0xc024cc) #31 0x0000000000c01db6 swift::TypeChecker::typeCheckTopLevelCodeDecl(swift::TopLevelCodeDecl*) (/path/to/swift/bin/swift+0xc01db6) #32 0x0000000000c15d0a swift::performTypeChecking(swift::SourceFile&, swift::TopLevelContext&, swift::OptionSet<swift::TypeCheckingFlags, unsigned int>, unsigned int, unsigned int) (/path/to/swift/bin/swift+0xc15d0a) #33 0x0000000000938c66 swift::CompilerInstance::performSema() (/path/to/swift/bin/swift+0x938c66) #34 0x000000000047ece5 performCompile(swift::CompilerInstance&, swift::CompilerInvocation&, llvm::ArrayRef<char const*>, int&, swift::FrontendObserver*) (/path/to/swift/bin/swift+0x47ece5) #35 0x000000000047db7f swift::performFrontend(llvm::ArrayRef<char const*>, char const*, void*, swift::FrontendObserver*) (/path/to/swift/bin/swift+0x47db7f) #36 0x000000000044509a main (/path/to/swift/bin/swift+0x44509a) #37 0x00007f9d7eeb5f45 __libc_start_main /build/eglibc-oGUzwX/eglibc-2.19/csu/libc-start.c:321:0 #38 0x0000000000442816 _start (/path/to/swift/bin/swift+0x442816) ```

Add test case for crash triggered in `swift::TypeChecker::typeCheckDecl`. Current number of unresolved compiler crashers: 122 (5184 resolved) Assertion failure in [`lib/Sema/TypeCheckDecl.cpp (line 6397)`](https://github.com/apple/swift/blob/master/lib/Sema/TypeCheckDecl.cpp#L6397): ``` Assertion `ED->getDeclContext()->isModuleScopeContext() && "non-top-level extensions make 'private' != 'fileprivate'"' failed. When executing: void <anonymous namespace>::DeclChecker::visitExtensionDecl(swift::ExtensionDecl *) ``` Assertion context: ``` const auto access = AA->getAccess(); AccessScope desiredAccessScope = AccessScope::getPublic(); switch (access) { case Accessibility::Private: assert(ED->getDeclContext()->isModuleScopeContext() && "non-top-level extensions make 'private' != 'fileprivate'"); SWIFT_FALLTHROUGH; case Accessibility::FilePrivate: { const DeclContext *DC = ED->getModuleScopeContext(); bool isPrivate = access == Accessibility::Private; desiredAccessScope = AccessScope(DC, isPrivate); ``` Stack trace: ``` #0 0x00000000031d10e8 llvm::sys::PrintStackTrace(llvm::raw_ostream&) (/path/to/swift/bin/swift+0x31d10e8) #1 0x00000000031d1936 SignalHandler(int) (/path/to/swift/bin/swift+0x31d1936) #2 0x00007f55513bb330 __restore_rt (/lib/x86_64-linux-gnu/libpthread.so.0+0x10330) #3 0x00007f554fb79c37 gsignal /build/eglibc-oGUzwX/eglibc-2.19/signal/../nptl/sysdeps/unix/sysv/linux/raise.c:56:0 #4 0x00007f554fb7d028 abort /build/eglibc-oGUzwX/eglibc-2.19/stdlib/abort.c:91:0 #5 0x00007f554fb72bf6 __assert_fail_base /build/eglibc-oGUzwX/eglibc-2.19/assert/assert.c:92:0 #6 0x00007f554fb72ca2 (/lib/x86_64-linux-gnu/libc.so.6+0x2fca2) #7 0x0000000000baa8db (/path/to/swift/bin/swift+0xbaa8db) #8 0x0000000000ba1da0 (anonymous namespace)::DeclChecker::visit(swift::Decl*) (/path/to/swift/bin/swift+0xba1da0) #9 0x0000000000baaecb (anonymous namespace)::DeclChecker::visitEnumDecl(swift::EnumDecl*) (/path/to/swift/bin/swift+0xbaaecb) #10 0x0000000000ba1e96 (anonymous namespace)::DeclChecker::visit(swift::Decl*) (/path/to/swift/bin/swift+0xba1e96) #11 0x0000000000ba1d06 swift::TypeChecker::typeCheckDecl(swift::Decl*, bool) (/path/to/swift/bin/swift+0xba1d06) #12 0x0000000000c0253f swift::ASTVisitor<(anonymous namespace)::StmtChecker, void, swift::Stmt*, void, void, void, void>::visit(swift::Stmt*) (/path/to/swift/bin/swift+0xc0253f) #13 0x0000000000c027ab swift::ASTVisitor<(anonymous namespace)::StmtChecker, void, swift::Stmt*, void, void, void, void>::visit(swift::Stmt*) (/path/to/swift/bin/swift+0xc027ab) #14 0x0000000000c024cc swift::ASTVisitor<(anonymous namespace)::StmtChecker, void, swift::Stmt*, void, void, void, void>::visit(swift::Stmt*) (/path/to/swift/bin/swift+0xc024cc) #15 0x0000000000c01db6 swift::TypeChecker::typeCheckTopLevelCodeDecl(swift::TopLevelCodeDecl*) (/path/to/swift/bin/swift+0xc01db6) #16 0x0000000000c15d0a swift::performTypeChecking(swift::SourceFile&, swift::TopLevelContext&, swift::OptionSet<swift::TypeCheckingFlags, unsigned int>, unsigned int, unsigned int) (/path/to/swift/bin/swift+0xc15d0a) #17 0x0000000000938c66 swift::CompilerInstance::performSema() (/path/to/swift/bin/swift+0x938c66) #18 0x000000000047ece5 performCompile(swift::CompilerInstance&, swift::CompilerInvocation&, llvm::ArrayRef<char const*>, int&, swift::FrontendObserver*) (/path/to/swift/bin/swift+0x47ece5) #19 0x000000000047db7f swift::performFrontend(llvm::ArrayRef<char const*>, char const*, void*, swift::FrontendObserver*) (/path/to/swift/bin/swift+0x47db7f) #20 0x000000000044509a main (/path/to/swift/bin/swift+0x44509a) #21 0x00007f554fb64f45 __libc_start_main /build/eglibc-oGUzwX/eglibc-2.19/csu/libc-start.c:321:0 #22 0x0000000000442816 _start (/path/to/swift/bin/swift+0x442816) ```

Add test case for crash triggered in `swift::ASTVisitor`. Current number of unresolved compiler crashers: 123 (5184 resolved) Assertion failure in [`lib/Sema/TypeCheckError.cpp (line 420)`](https://github.com/apple/swift/blob/master/lib/Sema/TypeCheckError.cpp#L420): ``` Assertion `args.size() > fnRef.getNumArgumentsForFullApply() && "partial application was throwing?"' failed. When executing: <anonymous>::Classification <anonymous namespace>::ApplyClassifier::classifyApply(swift::ApplyExpr *) ``` Assertion context: ``` // If we're applying more arguments than the natural argument // count, then this is a call to the opaque value returned from // the function. if (args.size() != fnRef.getNumArgumentsForFullApply()) { assert(args.size() > fnRef.getNumArgumentsForFullApply() && "partial application was throwing?"); return Classification::forThrow(PotentialReason::forThrowingApply()); } // If the function's body is 'rethrows' for the number of // arguments we gave it, apply the rethrows logic. ``` Stack trace: ``` #0 0x00000000031d10e8 llvm::sys::PrintStackTrace(llvm::raw_ostream&) (/path/to/swift/bin/swift+0x31d10e8) #1 0x00000000031d1936 SignalHandler(int) (/path/to/swift/bin/swift+0x31d1936) #2 0x00007f8d39b04330 __restore_rt (/lib/x86_64-linux-gnu/libpthread.so.0+0x10330) #3 0x00007f8d382c2c37 gsignal /build/eglibc-oGUzwX/eglibc-2.19/signal/../nptl/sysdeps/unix/sysv/linux/raise.c:56:0 #4 0x00007f8d382c6028 abort /build/eglibc-oGUzwX/eglibc-2.19/stdlib/abort.c:91:0 #5 0x00007f8d382bbbf6 __assert_fail_base /build/eglibc-oGUzwX/eglibc-2.19/assert/assert.c:92:0 #6 0x00007f8d382bbca2 (/lib/x86_64-linux-gnu/libc.so.6+0x2fca2) #7 0x0000000000bc7213 (/path/to/swift/bin/swift+0xbc7213) #8 0x0000000000bc5c44 (anonymous namespace)::ErrorHandlingWalker<(anonymous namespace)::CheckErrorCoverage>::walkToExprPre(swift::Expr*) (/path/to/swift/bin/swift+0xbc5c44) #9 0x0000000000d6a0c3 (anonymous namespace)::Traversal::visit(swift::Expr*) (/path/to/swift/bin/swift+0xd6a0c3) #10 0x0000000000d678ef swift::ASTVisitor<(anonymous namespace)::Traversal, swift::Expr*, swift::Stmt*, bool, swift::Pattern*, bool, void>::visit(swift::Stmt*) (/path/to/swift/bin/swift+0xd678ef) #11 0x0000000000d65a2e swift::Stmt::walk(swift::ASTWalker&) (/path/to/swift/bin/swift+0xd65a2e) #12 0x0000000000bc56f8 swift::TypeChecker::checkTopLevelErrorHandling(swift::TopLevelCodeDecl*) (/path/to/swift/bin/swift+0xbc56f8) #13 0x0000000000c01e01 swift::TypeChecker::typeCheckTopLevelCodeDecl(swift::TopLevelCodeDecl*) (/path/to/swift/bin/swift+0xc01e01) #14 0x0000000000c15d0a swift::performTypeChecking(swift::SourceFile&, swift::TopLevelContext&, swift::OptionSet<swift::TypeCheckingFlags, unsigned int>, unsigned int, unsigned int) (/path/to/swift/bin/swift+0xc15d0a) #15 0x0000000000938c66 swift::CompilerInstance::performSema() (/path/to/swift/bin/swift+0x938c66) #16 0x000000000047ece5 performCompile(swift::CompilerInstance&, swift::CompilerInvocation&, llvm::ArrayRef<char const*>, int&, swift::FrontendObserver*) (/path/to/swift/bin/swift+0x47ece5) #17 0x000000000047db7f swift::performFrontend(llvm::ArrayRef<char const*>, char const*, void*, swift::FrontendObserver*) (/path/to/swift/bin/swift+0x47db7f) #18 0x000000000044509a main (/path/to/swift/bin/swift+0x44509a) #19 0x00007f8d382adf45 __libc_start_main /build/eglibc-oGUzwX/eglibc-2.19/csu/libc-start.c:321:0 #20 0x0000000000442816 _start (/path/to/swift/bin/swift+0x442816) ```

…edGeneric(...) Add test case for crash triggered in `swift::TypeBase::isUnspecializedGeneric(...)`. Current number of unresolved compiler crashers: 124 (5184 resolved) Stack trace: ``` #0 0x00000000031d10e8 llvm::sys::PrintStackTrace(llvm::raw_ostream&) (/path/to/swift/bin/swift+0x31d10e8) #1 0x00000000031d1936 SignalHandler(int) (/path/to/swift/bin/swift+0x31d1936) #2 0x00007fd429b2e330 __restore_rt (/lib/x86_64-linux-gnu/libpthread.so.0+0x10330) #3 0x00007fd4282ecc37 gsignal /build/eglibc-oGUzwX/eglibc-2.19/signal/../nptl/sysdeps/unix/sysv/linux/raise.c:56:0 #4 0x00007fd4282f0028 abort /build/eglibc-oGUzwX/eglibc-2.19/stdlib/abort.c:91:0 #5 0x0000000003179afd llvm::llvm_unreachable_internal(char const*, char const*, unsigned int) (/path/to/swift/bin/swift+0x3179afd) #6 0x0000000000ddbebf swift::TypeBase::isUnspecializedGeneric() (/path/to/swift/bin/swift+0xddbebf) #7 0x0000000000c8e09a swift::constraints::ConstraintSystem::solveSimplified(llvm::SmallVectorImpl<swift::constraints::Solution>&, swift::FreeTypeVariableBinding) (/path/to/swift/bin/swift+0xc8e09a) #8 0x0000000000c8b369 swift::constraints::ConstraintSystem::solveRec(llvm::SmallVectorImpl<swift::constraints::Solution>&, swift::FreeTypeVariableBinding) (/path/to/swift/bin/swift+0xc8b369) #9 0x0000000000c8ad49 swift::constraints::ConstraintSystem::solve(llvm::SmallVectorImpl<swift::constraints::Solution>&, swift::FreeTypeVariableBinding) (/path/to/swift/bin/swift+0xc8ad49) #10 0x0000000000c8d51d swift::constraints::ConstraintSystem::solve(swift::Expr*&, swift::Type, swift::ExprTypeCheckListener*, llvm::SmallVectorImpl<swift::constraints::Solution>&, swift::FreeTypeVariableBinding) (/path/to/swift/bin/swift+0xc8d51d) #11 0x0000000000b8ae7b swift::TypeChecker::solveForExpression(swift::Expr*&, swift::DeclContext*, swift::Type, swift::FreeTypeVariableBinding, swift::ExprTypeCheckListener*, swift::constraints::ConstraintSystem&, llvm::SmallVectorImpl<swift::constraints::Solution>&, swift::OptionSet<swift::TypeCheckExprFlags, unsigned int>) (/path/to/swift/bin/swift+0xb8ae7b) #12 0x0000000000b8d96e swift::TypeChecker::typeCheckExpression(swift::Expr*&, swift::DeclContext*, swift::TypeLoc, swift::ContextualTypePurpose, swift::OptionSet<swift::TypeCheckExprFlags, unsigned int>, swift::ExprTypeCheckListener*, swift::constraints::ConstraintSystem*) (/path/to/swift/bin/swift+0xb8d96e) #13 0x0000000000c02594 swift::ASTVisitor<(anonymous namespace)::StmtChecker, void, swift::Stmt*, void, void, void, void>::visit(swift::Stmt*) (/path/to/swift/bin/swift+0xc02594) #14 0x0000000000c01db6 swift::TypeChecker::typeCheckTopLevelCodeDecl(swift::TopLevelCodeDecl*) (/path/to/swift/bin/swift+0xc01db6) #15 0x0000000000c15d0a swift::performTypeChecking(swift::SourceFile&, swift::TopLevelContext&, swift::OptionSet<swift::TypeCheckingFlags, unsigned int>, unsigned int, unsigned int) (/path/to/swift/bin/swift+0xc15d0a) #16 0x0000000000938c66 swift::CompilerInstance::performSema() (/path/to/swift/bin/swift+0x938c66) #17 0x000000000047ece5 performCompile(swift::CompilerInstance&, swift::CompilerInvocation&, llvm::ArrayRef<char const*>, int&, swift::FrontendObserver*) (/path/to/swift/bin/swift+0x47ece5) #18 0x000000000047db7f swift::performFrontend(llvm::ArrayRef<char const*>, char const*, void*, swift::FrontendObserver*) (/path/to/swift/bin/swift+0x47db7f) #19 0x000000000044509a main (/path/to/swift/bin/swift+0x44509a) #20 0x00007fd4282d7f45 __libc_start_main /build/eglibc-oGUzwX/eglibc-2.19/csu/libc-start.c:321:0 #21 0x0000000000442816 _start (/path/to/swift/bin/swift+0x442816) ```

Add test case for crash triggered in `swift::ASTVisitor`. Current number of unresolved compiler crashers: 125 (5184 resolved) Stack trace: ``` ))#0 0x00000000031d2438 llvm::sys::PrintStackTrace(llvm::raw_ostream&) (/path/to/swift/bin/swift+0x31d2438) #1 0x00000000031d2c86 SignalHandler(int) (/path/to/swift/bin/swift+0x31d2c86) #2 0x00007f4a6f296330 __restore_rt (/lib/x86_64-linux-gnu/libpthread.so.0+0x10330) #3 0x00007f4a6da54c37 gsignal /build/eglibc-oGUzwX/eglibc-2.19/signal/../nptl/sysdeps/unix/sysv/linux/raise.c:56:0 #4 0x00007f4a6da58028 abort /build/eglibc-oGUzwX/eglibc-2.19/stdlib/abort.c:91:0 #5 0x0000000000d57ff5 (anonymous namespace)::Verifier::walkToStmtPost(swift::Stmt*) (/path/to/swift/bin/swift+0xd57ff5) #6 0x0000000000d68010 swift::ASTVisitor<(anonymous namespace)::Traversal, swift::Expr*, swift::Stmt*, bool, swift::Pattern*, bool, void>::visit(swift::Stmt*) (/path/to/swift/bin/swift+0xd68010) #7 0x0000000000d6692e (anonymous namespace)::Traversal::doIt(swift::Decl*) (/path/to/swift/bin/swift+0xd6692e) #8 0x0000000000d66544 swift::Decl::walk(swift::ASTWalker&) (/path/to/swift/bin/swift+0xd66544) #9 0x0000000000dbbfae swift::SourceFile::walk(swift::ASTWalker&) (/path/to/swift/bin/swift+0xdbbfae) #10 0x0000000000d4e13c swift::verify(swift::SourceFile&) (/path/to/swift/bin/swift+0xd4e13c) #11 0x0000000000afc803 swift::Parser::parseTopLevel() (/path/to/swift/bin/swift+0xafc803) #12 0x0000000000b33b00 swift::parseIntoSourceFile(swift::SourceFile&, unsigned int, bool*, swift::SILParserState*, swift::PersistentParserState*, swift::DelayedParsingCallbacks*) (/path/to/swift/bin/swift+0xb33b00) #13 0x0000000000938c43 swift::CompilerInstance::performSema() (/path/to/swift/bin/swift+0x938c43) #14 0x000000000047ece5 performCompile(swift::CompilerInstance&, swift::CompilerInvocation&, llvm::ArrayRef<char const*>, int&, swift::FrontendObserver*) (/path/to/swift/bin/swift+0x47ece5) #15 0x000000000047db7f swift::performFrontend(llvm::ArrayRef<char const*>, char const*, void*, swift::FrontendObserver*) (/path/to/swift/bin/swift+0x47db7f) #16 0x000000000044509a main (/path/to/swift/bin/swift+0x44509a) #17 0x00007f4a6da3ff45 __libc_start_main /build/eglibc-oGUzwX/eglibc-2.19/csu/libc-start.c:321:0 #18 0x0000000000442816 _start (/path/to/swift/bin/swift+0x442816) ```

Add test case for crash triggered in `swift::ASTVisitor`. Current number of unresolved compiler crashers: 126 (5184 resolved) Assertion failure in [`include/swift/Basic/SourceLoc.h verifying (line 93 verifying)`](https://github.com/apple/swift/blob/master/include/swift/Basic/SourceLoc.h verifying#L93 verifying): ``` Assertion `Start.isValid() == End.isValid() && "Start and end should either both be valid or both be invalid!"' failed. Assertion `Start.isValid() == End.isValid() && "Start and end should either both be valid or both be invalid!"' failed. When executing: swift::SourceRange::SourceRange(swift::SourceLoc, swift::SourceLoc) swift::SourceRange::SourceRange(swift::SourceLoc, swift::SourceLoc) ``` Assertion context: ``` ``` Stack trace: ``` #0 0x00000000031d2438 llvm::sys::PrintStackTrace(llvm::raw_ostream&) (/path/to/swift/bin/swift+0x31d2438) #1 0x00000000031d2c86 SignalHandler(int) (/path/to/swift/bin/swift+0x31d2c86) #2 0x00007f4436ff2330 __restore_rt (/lib/x86_64-linux-gnu/libpthread.so.0+0x10330) #3 0x00007f44357b0c37 gsignal /build/eglibc-oGUzwX/eglibc-2.19/signal/../nptl/sysdeps/unix/sysv/linux/raise.c:56:0 #4 0x00007f44357b4028 abort /build/eglibc-oGUzwX/eglibc-2.19/stdlib/abort.c:91:0 #5 0x00007f44357a9bf6 __assert_fail_base /build/eglibc-oGUzwX/eglibc-2.19/assert/assert.c:92:0 #6 0x00007f44357a9ca2 (/lib/x86_64-linux-gnu/libc.so.6+0x2fca2) #7 0x0000000000dce154 (/path/to/swift/bin/swift+0xdce154) #8 0x0000000000d60b92 (anonymous namespace)::Verifier::checkSourceRanges(swift::Pattern*) (/path/to/swift/bin/swift+0xd60b92) #9 0x0000000000d58667 (anonymous namespace)::Verifier::walkToPatternPost(swift::Pattern*) (/path/to/swift/bin/swift+0xd58667) #10 0x0000000000d68a85 swift::ASTVisitor<(anonymous namespace)::Traversal, swift::Expr*, swift::Stmt*, bool, swift::Pattern*, bool, void>::visit(swift::Stmt*) (/path/to/swift/bin/swift+0xd68a85) #11 0x0000000000d689d5 swift::ASTVisitor<(anonymous namespace)::Traversal, swift::Expr*, swift::Stmt*, bool, swift::Pattern*, bool, void>::visit(swift::Stmt*) (/path/to/swift/bin/swift+0xd689d5) #12 0x0000000000d67fec swift::ASTVisitor<(anonymous namespace)::Traversal, swift::Expr*, swift::Stmt*, bool, swift::Pattern*, bool, void>::visit(swift::Stmt*) (/path/to/swift/bin/swift+0xd67fec) #13 0x0000000000d6692e (anonymous namespace)::Traversal::doIt(swift::Decl*) (/path/to/swift/bin/swift+0xd6692e) #14 0x0000000000d66544 swift::Decl::walk(swift::ASTWalker&) (/path/to/swift/bin/swift+0xd66544) #15 0x0000000000dbbfae swift::SourceFile::walk(swift::ASTWalker&) (/path/to/swift/bin/swift+0xdbbfae) #16 0x0000000000d4e13c swift::verify(swift::SourceFile&) (/path/to/swift/bin/swift+0xd4e13c) #17 0x0000000000c15e52 swift::performTypeChecking(swift::SourceFile&, swift::TopLevelContext&, swift::OptionSet<swift::TypeCheckingFlags, unsigned int>, unsigned int, unsigned int) (/path/to/swift/bin/swift+0xc15e52) #18 0x0000000000938c66 swift::CompilerInstance::performSema() (/path/to/swift/bin/swift+0x938c66) #19 0x000000000047ece5 performCompile(swift::CompilerInstance&, swift::CompilerInvocation&, llvm::ArrayRef<char const*>, int&, swift::FrontendObserver*) (/path/to/swift/bin/swift+0x47ece5) #20 0x000000000047db7f swift::performFrontend(llvm::ArrayRef<char const*>, char const*, void*, swift::FrontendObserver*) (/path/to/swift/bin/swift+0x47db7f) #21 0x000000000044509a main (/path/to/swift/bin/swift+0x44509a) #22 0x00007f443579bf45 __libc_start_main /build/eglibc-oGUzwX/eglibc-2.19/csu/libc-start.c:321:0 #23 0x0000000000442816 _start (/path/to/swift/bin/swift+0x442816) ```

Add test case for crash triggered in `swift::TypeChecker::typeCheckDecl`. Current number of unresolved compiler crashers: 127 (5184 resolved) Stack trace: ``` #0 0x00000000031d2438 llvm::sys::PrintStackTrace(llvm::raw_ostream&) (/path/to/swift/bin/swift+0x31d2438) #1 0x00000000031d2c86 SignalHandler(int) (/path/to/swift/bin/swift+0x31d2c86) #2 0x00007f6e0c388330 __restore_rt (/lib/x86_64-linux-gnu/libpthread.so.0+0x10330) #3 0x00007f6e0ab46c37 gsignal /build/eglibc-oGUzwX/eglibc-2.19/signal/../nptl/sysdeps/unix/sysv/linux/raise.c:56:0 #4 0x00007f6e0ab4a028 abort /build/eglibc-oGUzwX/eglibc-2.19/stdlib/abort.c:91:0 #5 0x000000000317ae4d llvm::llvm_unreachable_internal(char const*, char const*, unsigned int) (/path/to/swift/bin/swift+0x317ae4d) #6 0x0000000000bb157b checkAccessibility(swift::TypeChecker&, swift::Decl const*) (/path/to/swift/bin/swift+0xbb157b) #7 0x0000000000babd88 (anonymous namespace)::DeclChecker::visitProtocolDecl(swift::ProtocolDecl*) (/path/to/swift/bin/swift+0xbabd88) #8 0x0000000000ba1ec6 (anonymous namespace)::DeclChecker::visit(swift::Decl*) (/path/to/swift/bin/swift+0xba1ec6) #9 0x0000000000ba1d06 swift::TypeChecker::typeCheckDecl(swift::Decl*, bool) (/path/to/swift/bin/swift+0xba1d06) #10 0x0000000000c15d1a swift::performTypeChecking(swift::SourceFile&, swift::TopLevelContext&, swift::OptionSet<swift::TypeCheckingFlags, unsigned int>, unsigned int, unsigned int) (/path/to/swift/bin/swift+0xc15d1a) #11 0x0000000000938c66 swift::CompilerInstance::performSema() (/path/to/swift/bin/swift+0x938c66) #12 0x000000000047ece5 performCompile(swift::CompilerInstance&, swift::CompilerInvocation&, llvm::ArrayRef<char const*>, int&, swift::FrontendObserver*) (/path/to/swift/bin/swift+0x47ece5) #13 0x000000000047db7f swift::performFrontend(llvm::ArrayRef<char const*>, char const*, void*, swift::FrontendObserver*) (/path/to/swift/bin/swift+0x47db7f) #14 0x000000000044509a main (/path/to/swift/bin/swift+0x44509a) #15 0x00007f6e0ab31f45 __libc_start_main /build/eglibc-oGUzwX/eglibc-2.19/csu/libc-start.c:321:0 #16 0x0000000000442816 _start (/path/to/swift/bin/swift+0x442816) ```

Add test case for crash triggered in `swift::ASTVisitor`. Current number of unresolved compiler crashers: 128 (5184 resolved) Assertion failure in [`include/swift/AST/ExprNodes.def (line 69)`](https://github.com/apple/swift/blob/master/include/swift/AST/ExprNodes.def#L69): ``` Assertion `(HadError || !M.is<SourceFile*>() || M.get<SourceFile*>()->ASTStage < SourceFile::TypeChecked) && "OverloadedDeclRef" "in wrong phase"' failed. When executing: virtual std::pair<bool, Expr *> <anonymous namespace>::Verifier::walkToExprPre(swift::Expr *) ``` Assertion context: ``` ``` Stack trace: ``` #0 0x00000000031d2438 llvm::sys::PrintStackTrace(llvm::raw_ostream&) (/path/to/swift/bin/swift+0x31d2438) #1 0x00000000031d2c86 SignalHandler(int) (/path/to/swift/bin/swift+0x31d2c86) #2 0x00007f4651c98330 __restore_rt (/lib/x86_64-linux-gnu/libpthread.so.0+0x10330) #3 0x00007f4650456c37 gsignal /build/eglibc-oGUzwX/eglibc-2.19/signal/../nptl/sysdeps/unix/sysv/linux/raise.c:56:0 #4 0x00007f465045a028 abort /build/eglibc-oGUzwX/eglibc-2.19/stdlib/abort.c:91:0 #5 0x00007f465044fbf6 __assert_fail_base /build/eglibc-oGUzwX/eglibc-2.19/assert/assert.c:92:0 #6 0x00007f465044fca2 (/lib/x86_64-linux-gnu/libc.so.6+0x2fca2) #7 0x0000000000d4e935 (/path/to/swift/bin/swift+0xd4e935) #8 0x0000000000d6b16b (anonymous namespace)::Traversal::visitApplyExpr(swift::ApplyExpr*) (/path/to/swift/bin/swift+0xd6b16b) #9 0x0000000000d6911a (anonymous namespace)::Traversal::visit(swift::Expr*) (/path/to/swift/bin/swift+0xd6911a) #10 0x0000000000d6808f swift::ASTVisitor<(anonymous namespace)::Traversal, swift::Expr*, swift::Stmt*, bool, swift::Pattern*, bool, void>::visit(swift::Stmt*) (/path/to/swift/bin/swift+0xd6808f) #11 0x0000000000d6692e (anonymous namespace)::Traversal::doIt(swift::Decl*) (/path/to/swift/bin/swift+0xd6692e) #12 0x0000000000d66544 swift::Decl::walk(swift::ASTWalker&) (/path/to/swift/bin/swift+0xd66544) #13 0x0000000000dbbfae swift::SourceFile::walk(swift::ASTWalker&) (/path/to/swift/bin/swift+0xdbbfae) #14 0x0000000000d4e13c swift::verify(swift::SourceFile&) (/path/to/swift/bin/swift+0xd4e13c) #15 0x0000000000c15e52 swift::performTypeChecking(swift::SourceFile&, swift::TopLevelContext&, swift::OptionSet<swift::TypeCheckingFlags, unsigned int>, unsigned int, unsigned int) (/path/to/swift/bin/swift+0xc15e52) #16 0x0000000000938c66 swift::CompilerInstance::performSema() (/path/to/swift/bin/swift+0x938c66) #17 0x000000000047ece5 performCompile(swift::CompilerInstance&, swift::CompilerInvocation&, llvm::ArrayRef<char const*>, int&, swift::FrontendObserver*) (/path/to/swift/bin/swift+0x47ece5) #18 0x000000000047db7f swift::performFrontend(llvm::ArrayRef<char const*>, char const*, void*, swift::FrontendObserver*) (/path/to/swift/bin/swift+0x47db7f) #19 0x000000000044509a main (/path/to/swift/bin/swift+0x44509a) #20 0x00007f4650441f45 __libc_start_main /build/eglibc-oGUzwX/eglibc-2.19/csu/libc-start.c:321:0 #21 0x0000000000442816 _start (/path/to/swift/bin/swift+0x442816) ```

…enceGroup Add test case for crash triggered in `swift::Parser::parseDeclPrecedenceGroup`. Current number of unresolved compiler crashers: 129 (5184 resolved) Assertion failure in [`lib/Parse/Parser.cpp (line 332)`](https://github.com/apple/swift/blob/master/lib/Parse/Parser.cpp#L332): ``` Assertion `Tok.isNot(tok::eof) && "Lexing past eof!"' failed. When executing: swift::SourceLoc swift::Parser::consumeToken() ``` Assertion context: ``` return L->peekNextToken(); } SourceLoc Parser::consumeToken() { SourceLoc Loc = Tok.getLoc(); assert(Tok.isNot(tok::eof) && "Lexing past eof!"); if (IsParsingInterfaceTokens && !Tok.getText().empty()) { SF.recordInterfaceToken(Tok.getText()); } ``` Stack trace: ``` #0 0x00000000031d2438 llvm::sys::PrintStackTrace(llvm::raw_ostream&) (/path/to/swift/bin/swift+0x31d2438) #1 0x00000000031d2c86 SignalHandler(int) (/path/to/swift/bin/swift+0x31d2c86) #2 0x00007ff9c3ba1330 __restore_rt (/lib/x86_64-linux-gnu/libpthread.so.0+0x10330) #3 0x00007ff9c235fc37 gsignal /build/eglibc-oGUzwX/eglibc-2.19/signal/../nptl/sysdeps/unix/sysv/linux/raise.c:56:0 #4 0x00007ff9c2363028 abort /build/eglibc-oGUzwX/eglibc-2.19/stdlib/abort.c:91:0 #5 0x00007ff9c2358bf6 __assert_fail_base /build/eglibc-oGUzwX/eglibc-2.19/assert/assert.c:92:0 #6 0x00007ff9c2358ca2 (/lib/x86_64-linux-gnu/libc.so.6+0x2fca2) #7 0x0000000000b34d95 (/path/to/swift/bin/swift+0xb34d95) #8 0x0000000000b0fa4d swift::Parser::parseDeclPrecedenceGroup(swift::OptionSet<swift::Parser::ParseDeclFlags, unsigned int>, swift::DeclAttributes&) (/path/to/swift/bin/swift+0xb0fa4d) #9 0x0000000000b0684a swift::Parser::parseDecl(swift::OptionSet<swift::Parser::ParseDeclFlags, unsigned int>, llvm::function_ref<void (swift::Decl*)>) (/path/to/swift/bin/swift+0xb0684a) #10 0x0000000000b6c3a9 swift::Parser::parseBraceItems(llvm::SmallVectorImpl<swift::ASTNode>&, swift::BraceItemListKind, swift::BraceItemListKind) (/path/to/swift/bin/swift+0xb6c3a9) #11 0x0000000000b27dd2 swift::Parser::parseExprClosure() (/path/to/swift/bin/swift+0xb27dd2) #12 0x0000000000b28752 swift::Parser::parseTrailingClosure(swift::SourceRange) (/path/to/swift/bin/swift+0xb28752) #13 0x0000000000b257df swift::Parser::parseExprList(swift::tok, swift::tok, bool, bool, swift::SourceLoc&, llvm::SmallVectorImpl<swift::Expr*>&, llvm::SmallVectorImpl<swift::Identifier>&, llvm::SmallVectorImpl<swift::SourceLoc>&, swift::SourceLoc&, swift::Expr*&) (/path/to/swift/bin/swift+0xb257df) #14 0x0000000000b27306 swift::Parser::parseExprCallSuffix(swift::ParserResult<swift::Expr>, bool) (/path/to/swift/bin/swift+0xb27306) #15 0x0000000000b21c16 swift::Parser::parseExprPostfix(swift::Diag<>, bool) (/path/to/swift/bin/swift+0xb21c16) #16 0x0000000000b1fced swift::Parser::parseExprUnary(swift::Diag<>, bool) (/path/to/swift/bin/swift+0xb1fced) #17 0x0000000000b1f5e1 swift::Parser::parseExprSequenceElement(swift::Diag<>, bool) (/path/to/swift/bin/swift+0xb1f5e1) #18 0x0000000000b1e77e swift::Parser::parseExprSequence(swift::Diag<>, bool, bool) (/path/to/swift/bin/swift+0xb1e77e) #19 0x0000000000b1e637 swift::Parser::parseExprImpl(swift::Diag<>, bool) (/path/to/swift/bin/swift+0xb1e637) #20 0x0000000000b6aab6 swift::Parser::parseExprOrStmt(swift::ASTNode&) (/path/to/swift/bin/swift+0xb6aab6) #21 0x0000000000b6c770 swift::Parser::parseBraceItems(llvm::SmallVectorImpl<swift::ASTNode>&, swift::BraceItemListKind, swift::BraceItemListKind) (/path/to/swift/bin/swift+0xb6c770) #22 0x0000000000afc65a swift::Parser::parseTopLevel() (/path/to/swift/bin/swift+0xafc65a) #23 0x0000000000b33b00 swift::parseIntoSourceFile(swift::SourceFile&, unsigned int, bool*, swift::SILParserState*, swift::PersistentParserState*, swift::DelayedParsingCallbacks*) (/path/to/swift/bin/swift+0xb33b00) #24 0x0000000000938c43 swift::CompilerInstance::performSema() (/path/to/swift/bin/swift+0x938c43) #25 0x000000000047ece5 performCompile(swift::CompilerInstance&, swift::CompilerInvocation&, llvm::ArrayRef<char const*>, int&, swift::FrontendObserver*) (/path/to/swift/bin/swift+0x47ece5) #26 0x000000000047db7f swift::performFrontend(llvm::ArrayRef<char const*>, char const*, void*, swift::FrontendObserver*) (/path/to/swift/bin/swift+0x47db7f) #27 0x000000000044509a main (/path/to/swift/bin/swift+0x44509a) #28 0x00007ff9c234af45 __libc_start_main /build/eglibc-oGUzwX/eglibc-2.19/csu/libc-start.c:321:0 #29 0x0000000000442816 _start (/path/to/swift/bin/swift+0x442816) ```

…erator Add test case for crash triggered in `swift::ProtocolConformance::operator`. Current number of unresolved compiler crashers: 130 (5184 resolved) Assertion failure in [`lib/AST/ProtocolConformance.cpp (line 574)`](https://github.com/apple/swift/blob/master/lib/AST/ProtocolConformance.cpp#L574): ``` Assertion `!isComplete() && "Missing inherited mapping in conformance"' failed. When executing: swift::ProtocolConformance *swift::ProtocolConformance::getInheritedConformance(swift::ProtocolDecl *) const ``` Assertion context: ``` if (inheritedMapping.first->inheritsFrom(protocol)) return inheritedMapping.second->getInheritedConformance(protocol); // The conformance must not be complete; resolve the inherited conformance // and try again. assert(!isComplete() && "Missing inherited mapping in conformance"); assert(C.getLazyResolver() && "Need a lazy resolver"); return C.getLazyResolver()->resolveInheritedConformance( getRootNormalConformance(), protocol); } ``` Stack trace: ``` #0 0x00000000031d2438 llvm::sys::PrintStackTrace(llvm::raw_ostream&) (/path/to/swift/bin/swift+0x31d2438) #1 0x00000000031d2c86 SignalHandler(int) (/path/to/swift/bin/swift+0x31d2c86) #2 0x00007f492a58b330 __restore_rt (/lib/x86_64-linux-gnu/libpthread.so.0+0x10330) #3 0x00007f4928d49c37 gsignal /build/eglibc-oGUzwX/eglibc-2.19/signal/../nptl/sysdeps/unix/sysv/linux/raise.c:56:0 #4 0x00007f4928d4d028 abort /build/eglibc-oGUzwX/eglibc-2.19/stdlib/abort.c:91:0 #5 0x00007f4928d42bf6 __assert_fail_base /build/eglibc-oGUzwX/eglibc-2.19/assert/assert.c:92:0 #6 0x00007f4928d42ca2 (/lib/x86_64-linux-gnu/libc.so.6+0x2fca2) #7 0x0000000000dd1d00 swift::ProtocolConformance::operator new(unsigned long, swift::ASTContext&, swift::AllocationArena, unsigned int) (/path/to/swift/bin/swift+0xdd1d00) #8 0x0000000000dd16f9 swift::ProtocolConformanceRef::getInherited(swift::ProtocolDecl*) const (/path/to/swift/bin/swift+0xdd16f9) #9 0x0000000000dd95d0 swift::SubstitutionMap::lookupConformance(swift::CanType, swift::ProtocolDecl*) const (/path/to/swift/bin/swift+0xdd95d0) #10 0x0000000000de3510 getMemberForBaseType(llvm::PointerUnion<swift::ModuleDecl*, swift::SubstitutionMap const*>, swift::Type, swift::Type, swift::AssociatedTypeDecl*, swift::Identifier, swift::OptionSet<swift::SubstFlags, unsigned int>) (/path/to/swift/bin/swift+0xde3510) #11 0x0000000000de7cac swift::Type llvm::function_ref<swift::Type (swift::Type)>::callback_fn<substType(swift::Type, llvm::PointerUnion<swift::ModuleDecl*, swift::SubstitutionMap const*>, llvm::DenseMap<swift::TypeBase*, swift::Type, llvm::DenseMapInfo<swift::TypeBase*>, llvm::detail::DenseMapPair<swift::TypeBase*, swift::Type> > const&, swift::OptionSet<swift::SubstFlags, unsigned int>)::$_9>(long, swift::Type) (/path/to/swift/bin/swift+0xde7cac) #12 0x0000000000de4313 swift::Type::transform(llvm::function_ref<swift::Type (swift::Type)>) const (/path/to/swift/bin/swift+0xde4313) #13 0x0000000000de0631 swift::Type::subst(swift::SubstitutionMap const&, swift::OptionSet<swift::SubstFlags, unsigned int>) const (/path/to/swift/bin/swift+0xde0631) #14 0x0000000000dd23ff swift::SpecializedProtocolConformance::getTypeWitnessSubstAndDecl(swift::AssociatedTypeDecl*, swift::LazyResolver*) const (/path/to/swift/bin/swift+0xdd23ff) #15 0x0000000000dd20b2 swift::ProtocolConformance::getTypeWitnessSubstAndDecl(swift::AssociatedTypeDecl*, swift::LazyResolver*) const (/path/to/swift/bin/swift+0xdd20b2) #16 0x0000000000de35fa getMemberForBaseType(llvm::PointerUnion<swift::ModuleDecl*, swift::SubstitutionMap const*>, swift::Type, swift::Type, swift::AssociatedTypeDecl*, swift::Identifier, swift::OptionSet<swift::SubstFlags, unsigned int>) (/path/to/swift/bin/swift+0xde35fa) #17 0x0000000000de7cac swift::Type llvm::function_ref<swift::Type (swift::Type)>::callback_fn<substType(swift::Type, llvm::PointerUnion<swift::ModuleDecl*, swift::SubstitutionMap const*>, llvm::DenseMap<swift::TypeBase*, swift::Type, llvm::DenseMapInfo<swift::TypeBase*>, llvm::detail::DenseMapPair<swift::TypeBase*, swift::Type> > const&, swift::OptionSet<swift::SubstFlags, unsigned int>)::$_9>(long, swift::Type) (/path/to/swift/bin/swift+0xde7cac) #18 0x0000000000de4313 swift::Type::transform(llvm::function_ref<swift::Type (swift::Type)>) const (/path/to/swift/bin/swift+0xde4313) #19 0x0000000000de3f4f swift::TypeBase::getTypeOfMember(swift::ModuleDecl*, swift::Type, swift::DeclContext const*) (/path/to/swift/bin/swift+0xde3f4f) #20 0x0000000000cb6590 swift::Type llvm::function_ref<swift::Type (swift::Type)>::callback_fn<swift::constraints::ConstraintSystem::simplifyType(swift::Type)::$_3>(long, swift::Type) (/path/to/swift/bin/swift+0xcb6590) #21 0x0000000000de4313 swift::Type::transform(llvm::function_ref<swift::Type (swift::Type)>) const (/path/to/swift/bin/swift+0xde4313) #22 0x0000000000cb2582 swift::constraints::ConstraintSystem::getFixedTypeRecursive(swift::Type, swift::OptionSet<swift::constraints::ConstraintSystem::TypeMatchFlags, unsigned int>&, bool, bool) (/path/to/swift/bin/swift+0xcb2582) #23 0x0000000000c7a5ae swift::constraints::ConstraintSystem::matchTypes(swift::Type, swift::Type, swift::constraints::ConstraintKind, swift::OptionSet<swift::constraints::ConstraintSystem::TypeMatchFlags, unsigned int>, swift::constraints::ConstraintLocatorBuilder) (/path/to/swift/bin/swift+0xc7a5ae) #24 0x0000000000c873f9 swift::constraints::ConstraintSystem::simplifyConstraint(swift::constraints::Constraint const&) (/path/to/swift/bin/swift+0xc873f9) #25 0x0000000000c8a52a swift::constraints::ConstraintSystem::simplify(bool) (/path/to/swift/bin/swift+0xc8a52a) #26 0x0000000000c8b972 swift::constraints::ConstraintSystem::solveRec(llvm::SmallVectorImpl<swift::constraints::Solution>&, swift::FreeTypeVariableBinding) (/path/to/swift/bin/swift+0xc8b972) #27 0x0000000000c8b4e9 swift::constraints::ConstraintSystem::solve(llvm::SmallVectorImpl<swift::constraints::Solution>&, swift::FreeTypeVariableBinding) (/path/to/swift/bin/swift+0xc8b4e9) #28 0x0000000000c8b41b swift::constraints::ConstraintSystem::solveSingle(swift::FreeTypeVariableBinding) (/path/to/swift/bin/swift+0xc8b41b) #29 0x0000000000bde987 swift::TypeChecker::isProtocolExtensionUsable(swift::DeclContext*, swift::Type, swift::ExtensionDecl*) (/path/to/swift/bin/swift+0xbde987) #30 0x0000000000c6a192 swift::isExtensionApplied(swift::DeclContext&, swift::Type, swift::ExtensionDecl const*) (/path/to/swift/bin/swift+0xc6a192) #31 0x0000000000da97d0 doGlobalExtensionLookup(swift::Type, swift::Type, llvm::SmallVectorImpl<swift::ValueDecl*>&, swift::DeclContext const*, (anonymous namespace)::LookupState, swift::DeclVisibilityKind, swift::LazyResolver*) (/path/to/swift/bin/swift+0xda97d0) #32 0x0000000000da80d4 lookupVisibleMemberDeclsImpl(swift::Type, swift::VisibleDeclConsumer&, swift::DeclContext const*, (anonymous namespace)::LookupState, swift::DeclVisibilityKind, swift::LazyResolver*, llvm::SmallPtrSet<swift::TypeDecl*, 8u>&) (/path/to/swift/bin/swift+0xda80d4) #33 0x0000000000da7b54 lookupVisibleMemberDeclsImpl(swift::Type, swift::VisibleDeclConsumer&, swift::DeclContext const*, (anonymous namespace)::LookupState, swift::DeclVisibilityKind, swift::LazyResolver*, llvm::SmallPtrSet<swift::TypeDecl*, 8u>&) (/path/to/swift/bin/swift+0xda7b54) #34 0x0000000000da7996 lookupVisibleMemberDecls(swift::Type, swift::VisibleDeclConsumer&, swift::DeclContext const*, (anonymous namespace)::LookupState, swift::DeclVisibilityKind, swift::LazyResolver*) (/path/to/swift/bin/swift+0xda7996) #35 0x0000000000bd09b6 swift::TypeChecker::performTypoCorrection(swift::DeclContext*, swift::DeclRefKind, swift::Type, swift::DeclName, swift::SourceLoc, swift::OptionSet<swift::NameLookupFlags, unsigned int>, swift::LookupResult&, unsigned int) (/path/to/swift/bin/swift+0xbd09b6) #36 0x0000000000c4768a (anonymous namespace)::FailureDiagnosis::diagnoseUnviableLookupResults(swift::constraints::MemberLookupResult&, swift::Type, swift::Expr*, swift::DeclName, swift::DeclNameLoc, swift::SourceLoc) (/path/to/swift/bin/swift+0xc4768a) #37 0x0000000000c4038e (anonymous namespace)::FailureDiagnosis::diagnoseConstraintFailure() (/path/to/swift/bin/swift+0xc4038e) #38 0x0000000000c3cad2 swift::constraints::ConstraintSystem::diagnoseFailureForExpr(swift::Expr*) (/path/to/swift/bin/swift+0xc3cad2) #39 0x0000000000c43210 swift::constraints::ConstraintSystem::salvage(llvm::SmallVectorImpl<swift::constraints::Solution>&, swift::Expr*) (/path/to/swift/bin/swift+0xc43210) #40 0x0000000000b8aecf swift::TypeChecker::solveForExpression(swift::Expr*&, swift::DeclContext*, swift::Type, swift::FreeTypeVariableBinding, swift::ExprTypeCheckListener*, swift::constraints::ConstraintSystem&, llvm::SmallVectorImpl<swift::constraints::Solution>&, swift::OptionSet<swift::TypeCheckExprFlags, unsigned int>) (/path/to/swift/bin/swift+0xb8aecf) #41 0x0000000000b8d96e swift::TypeChecker::typeCheckExpression(swift::Expr*&, swift::DeclContext*, swift::TypeLoc, swift::ContextualTypePurpose, swift::OptionSet<swift::TypeCheckExprFlags, unsigned int>, swift::ExprTypeCheckListener*, swift::constraints::ConstraintSystem*) (/path/to/swift/bin/swift+0xb8d96e) #42 0x0000000000c02594 swift::ASTVisitor<(anonymous namespace)::StmtChecker, void, swift::Stmt*, void, void, void, void>::visit(swift::Stmt*) (/path/to/swift/bin/swift+0xc02594) #43 0x0000000000c01db6 swift::TypeChecker::typeCheckTopLevelCodeDecl(swift::TopLevelCodeDecl*) (/path/to/swift/bin/swift+0xc01db6) #44 0x0000000000c15d0a swift::performTypeChecking(swift::SourceFile&, swift::TopLevelContext&, swift::OptionSet<swift::TypeCheckingFlags, unsigned int>, unsigned int, unsigned int) (/path/to/swift/bin/swift+0xc15d0a) #45 0x0000000000938c66 swift::CompilerInstance::performSema() (/path/to/swift/bin/swift+0x938c66) #46 0x000000000047ece5 performCompile(swift::CompilerInstance&, swift::CompilerInvocation&, llvm::ArrayRef<char const*>, int&, swift::FrontendObserver*) (/path/to/swift/bin/swift+0x47ece5) #47 0x000000000047db7f swift::performFrontend(llvm::ArrayRef<char const*>, char const*, void*, swift::FrontendObserver*) (/path/to/swift/bin/swift+0x47db7f) #48 0x000000000044509a main (/path/to/swift/bin/swift+0x44509a) #49 0x00007f4928d34f45 __libc_start_main /build/eglibc-oGUzwX/eglibc-2.19/csu/libc-start.c:321:0 #50 0x0000000000442816 _start (/path/to/swift/bin/swift+0x442816) ```

Add test case for crash triggered in `swift::ASTVisitor`. Current number of unresolved compiler crashers: 131 (5184 resolved) Stack trace: ``` a type variable escaped the type checker#0 0x00000000031d2438 llvm::sys::PrintStackTrace(llvm::raw_ostream&) (/path/to/swift/bin/swift+0x31d2438) #1 0x00000000031d2c86 SignalHandler(int) (/path/to/swift/bin/swift+0x31d2c86) #2 0x00007fef61a66330 __restore_rt (/lib/x86_64-linux-gnu/libpthread.so.0+0x10330) #3 0x00007fef60224c37 gsignal /build/eglibc-oGUzwX/eglibc-2.19/signal/../nptl/sysdeps/unix/sysv/linux/raise.c:56:0 #4 0x00007fef60228028 abort /build/eglibc-oGUzwX/eglibc-2.19/stdlib/abort.c:91:0 #5 0x0000000000d5c9ac (anonymous namespace)::Verifier::verifyChecked(swift::Type, llvm::SmallPtrSet<swift::ArchetypeType*, 4u>&) (/path/to/swift/bin/swift+0xd5c9ac) #6 0x0000000000d4f68a (anonymous namespace)::Verifier::walkToExprPost(swift::Expr*) (/path/to/swift/bin/swift+0xd4f68a) #7 0x0000000000d69564 (anonymous namespace)::Traversal::visit(swift::Expr*) (/path/to/swift/bin/swift+0xd69564) #8 0x0000000000d6812a swift::ASTVisitor<(anonymous namespace)::Traversal, swift::Expr*, swift::Stmt*, bool, swift::Pattern*, bool, void>::visit(swift::Stmt*) (/path/to/swift/bin/swift+0xd6812a) #9 0x0000000000d67fec swift::ASTVisitor<(anonymous namespace)::Traversal, swift::Expr*, swift::Stmt*, bool, swift::Pattern*, bool, void>::visit(swift::Stmt*) (/path/to/swift/bin/swift+0xd67fec) #10 0x0000000000d6ae03 (anonymous namespace)::Traversal::visit(swift::Expr*) (/path/to/swift/bin/swift+0xd6ae03) #11 0x0000000000d6808f swift::ASTVisitor<(anonymous namespace)::Traversal, swift::Expr*, swift::Stmt*, bool, swift::Pattern*, bool, void>::visit(swift::Stmt*) (/path/to/swift/bin/swift+0xd6808f) #12 0x0000000000d6692e (anonymous namespace)::Traversal::doIt(swift::Decl*) (/path/to/swift/bin/swift+0xd6692e) #13 0x0000000000d66544 swift::Decl::walk(swift::ASTWalker&) (/path/to/swift/bin/swift+0xd66544) #14 0x0000000000dbbfae swift::SourceFile::walk(swift::ASTWalker&) (/path/to/swift/bin/swift+0xdbbfae) #15 0x0000000000d4e13c swift::verify(swift::SourceFile&) (/path/to/swift/bin/swift+0xd4e13c) #16 0x0000000000c15e52 swift::performTypeChecking(swift::SourceFile&, swift::TopLevelContext&, swift::OptionSet<swift::TypeCheckingFlags, unsigned int>, unsigned int, unsigned int) (/path/to/swift/bin/swift+0xc15e52) #17 0x0000000000938c66 swift::CompilerInstance::performSema() (/path/to/swift/bin/swift+0x938c66) #18 0x000000000047ece5 performCompile(swift::CompilerInstance&, swift::CompilerInvocation&, llvm::ArrayRef<char const*>, int&, swift::FrontendObserver*) (/path/to/swift/bin/swift+0x47ece5) #19 0x000000000047db7f swift::performFrontend(llvm::ArrayRef<char const*>, char const*, void*, swift::FrontendObserver*) (/path/to/swift/bin/swift+0x47db7f) #20 0x000000000044509a main (/path/to/swift/bin/swift+0x44509a) #21 0x00007fef6020ff45 __libc_start_main /build/eglibc-oGUzwX/eglibc-2.19/csu/libc-start.c:321:0 #22 0x0000000000442816 _start (/path/to/swift/bin/swift+0x442816) ```

Add test case for crash triggered in `swift::ASTVisitor`. Current number of unresolved compiler crashers: 132 (5184 resolved) Assertion failure in [`lib/Sema/CSApply.cpp (line 4676)`](https://github.com/apple/swift/blob/master/lib/Sema/CSApply.cpp#L4676): ``` Assertion `!failed && "Call arguments did not match up?"' failed. When executing: swift::Expr *<anonymous namespace>::ExprRewriter::coerceCallArguments(swift::Expr *, swift::Type, llvm::PointerUnion<ApplyExpr *, LevelTy>, ArrayRef<swift::Identifier>, bool, swift::constraints::ConstraintLocatorBuilder) ``` Assertion context: ``` SmallVector<ParamBinding, 4> parameterBindings; bool failed = constraints::matchCallArguments(args, params, hasTrailingClosure, /*allowFixes=*/false, listener, parameterBindings); assert(!failed && "Call arguments did not match up?"); (void)failed; // We should either have parentheses or a tuple. TupleExpr *argTuple = dyn_cast<TupleExpr>(arg); ParenExpr *argParen = dyn_cast<ParenExpr>(arg); ``` Stack trace: ``` #0 0x00000000031d2438 llvm::sys::PrintStackTrace(llvm::raw_ostream&) (/path/to/swift/bin/swift+0x31d2438) #1 0x00000000031d2c86 SignalHandler(int) (/path/to/swift/bin/swift+0x31d2c86) #2 0x00007f72b981e330 __restore_rt (/lib/x86_64-linux-gnu/libpthread.so.0+0x10330) #3 0x00007f72b7fdcc37 gsignal /build/eglibc-oGUzwX/eglibc-2.19/signal/../nptl/sysdeps/unix/sysv/linux/raise.c:56:0 #4 0x00007f72b7fe0028 abort /build/eglibc-oGUzwX/eglibc-2.19/stdlib/abort.c:91:0 #5 0x00007f72b7fd5bf6 __assert_fail_base /build/eglibc-oGUzwX/eglibc-2.19/assert/assert.c:92:0 #6 0x00007f72b7fd5ca2 (/lib/x86_64-linux-gnu/libc.so.6+0x2fca2) #7 0x0000000000c285e4 (/path/to/swift/bin/swift+0xc285e4) #8 0x0000000000c2563e (anonymous namespace)::ExprRewriter::finishApply(swift::ApplyExpr*, swift::Type, swift::constraints::ConstraintLocatorBuilder) (/path/to/swift/bin/swift+0xc2563e) #9 0x0000000000c25e4f (anonymous namespace)::ExprRewriter::finishApply(swift::ApplyExpr*, swift::Type, swift::constraints::ConstraintLocatorBuilder) (/path/to/swift/bin/swift+0xc25e4f) #10 0x0000000000c2b4ce swift::ASTVisitor<(anonymous namespace)::ExprRewriter, swift::Expr*, void, void, void, void, void>::visit(swift::Expr*) (/path/to/swift/bin/swift+0xc2b4ce) #11 0x0000000000c230c0 (anonymous namespace)::ExprRewriter::walkToExprPost(swift::Expr*) (/path/to/swift/bin/swift+0xc230c0) #12 0x0000000000c34cf0 (anonymous namespace)::ExprWalker::walkToExprPost(swift::Expr*) (/path/to/swift/bin/swift+0xc34cf0) #13 0x0000000000d66175 swift::Expr::walk(swift::ASTWalker&) (/path/to/swift/bin/swift+0xd66175) #14 0x0000000000c1fb22 swift::constraints::ConstraintSystem::applySolution(swift::constraints::Solution&, swift::Expr*, swift::Type, bool, bool, bool) (/path/to/swift/bin/swift+0xc1fb22) #15 0x0000000000b8da04 swift::TypeChecker::typeCheckExpression(swift::Expr*&, swift::DeclContext*, swift::TypeLoc, swift::ContextualTypePurpose, swift::OptionSet<swift::TypeCheckExprFlags, unsigned int>, swift::ExprTypeCheckListener*, swift::constraints::ConstraintSystem*) (/path/to/swift/bin/swift+0xb8da04) #16 0x0000000000c44105 (anonymous namespace)::FailureDiagnosis::typeCheckChildIndependently(swift::Expr*, swift::Type, swift::ContextualTypePurpose, swift::OptionSet<TCCFlags, unsigned int>, swift::ExprTypeCheckListener*) (/path/to/swift/bin/swift+0xc44105) #17 0x0000000000c4de56 swift::ASTVisitor<(anonymous namespace)::FailureDiagnosis, bool, void, void, void, void, void>::visit(swift::Expr*) (/path/to/swift/bin/swift+0xc4de56) #18 0x0000000000c3cab6 swift::constraints::ConstraintSystem::diagnoseFailureForExpr(swift::Expr*) (/path/to/swift/bin/swift+0xc3cab6) #19 0x0000000000c43210 swift::constraints::ConstraintSystem::salvage(llvm::SmallVectorImpl<swift::constraints::Solution>&, swift::Expr*) (/path/to/swift/bin/swift+0xc43210) #20 0x0000000000b8aecf swift::TypeChecker::solveForExpression(swift::Expr*&, swift::DeclContext*, swift::Type, swift::FreeTypeVariableBinding, swift::ExprTypeCheckListener*, swift::constraints::ConstraintSystem&, llvm::SmallVectorImpl<swift::constraints::Solution>&, swift::OptionSet<swift::TypeCheckExprFlags, unsigned int>) (/path/to/swift/bin/swift+0xb8aecf) #21 0x0000000000b8d96e swift::TypeChecker::typeCheckExpression(swift::Expr*&, swift::DeclContext*, swift::TypeLoc, swift::ContextualTypePurpose, swift::OptionSet<swift::TypeCheckExprFlags, unsigned int>, swift::ExprTypeCheckListener*, swift::constraints::ConstraintSystem*) (/path/to/swift/bin/swift+0xb8d96e) #22 0x0000000000c02594 swift::ASTVisitor<(anonymous namespace)::StmtChecker, void, swift::Stmt*, void, void, void, void>::visit(swift::Stmt*) (/path/to/swift/bin/swift+0xc02594) #23 0x0000000000c01db6 swift::TypeChecker::typeCheckTopLevelCodeDecl(swift::TopLevelCodeDecl*) (/path/to/swift/bin/swift+0xc01db6) #24 0x0000000000c15d0a swift::performTypeChecking(swift::SourceFile&, swift::TopLevelContext&, swift::OptionSet<swift::TypeCheckingFlags, unsigned int>, unsigned int, unsigned int) (/path/to/swift/bin/swift+0xc15d0a) #25 0x0000000000938c66 swift::CompilerInstance::performSema() (/path/to/swift/bin/swift+0x938c66) #26 0x000000000047ece5 performCompile(swift::CompilerInstance&, swift::CompilerInvocation&, llvm::ArrayRef<char const*>, int&, swift::FrontendObserver*) (/path/to/swift/bin/swift+0x47ece5) #27 0x000000000047db7f swift::performFrontend(llvm::ArrayRef<char const*>, char const*, void*, swift::FrontendObserver*) (/path/to/swift/bin/swift+0x47db7f) #28 0x000000000044509a main (/path/to/swift/bin/swift+0x44509a) #29 0x00007f72b7fc7f45 __libc_start_main /build/eglibc-oGUzwX/eglibc-2.19/csu/libc-start.c:321:0 #30 0x0000000000442816 _start (/path/to/swift/bin/swift+0x442816) ```

* [WASM] Build ImageInspectionShared even on macOS ImageInspectionShared was built only if host OS is Linux. But it's necessary when primary sdk is WASM. * [WASM] Use llvm-ar instead of ranlib on macOS Specify ar binary through extra-cmake-options * [WASM] Install llvm through HomeBrew to use llvm-ar * [WASM] Use llvm-ranlib instead of ranlib of Xcode * [WASM] Read offset as pointer when target is wasm Because WASM doesn't support relative pointer, compiler emit direct address instead of offset from current address. * [WASM] Copy SwiftRT-ELF.cpp into SwiftRT-WASM.cpp * [WASM] Emit empty swift5 sections if there aren't * [WASM] Remove swift_end and swift_start files

Update typed throws implementation

Use custom hash table as node lookup table

Windows: correct some errors in the SDK manifest

nadavrot added 10 commits November 22, 2015 19:37

[MemoryBehavior] Cleanup and document logic for access to readonly me…

3be2be5

…mory location.

[AliasAnalysis] Document the AliasResult enum. NFC.

f6d6f31

[AliasAnalysis] Document and roll the alias() family of methods. NFC.

c1dce5c

Document alias() and roll the mayAlias() family of methods into a single function.

[AliasAnalysis] Remove the default argument from getMemoryBehavior.

4b2da0a

ObserveRetains is not an obvious default and it does not make sense to have it as a default argument.

Abbreviate AliasResult.

08d75ca

[AliasAnalysis] Clean some of the docs.

2276a93

Move some comments from the definition to the decleration and tidy some of the comments.

[AliasAnalysis] Rename getMemoryBehavior.

96ab8d8

getMemoryBehavior is also used by SILInstruction. This commit renames getMemoryBehavior to computeMemoryBehavior and cleans some of the code that touches it.

[AliasAnalysis] Rename getMemoryBehavior.

c7a4637

getMemoryBehavior is also used by SILInstruction. This commit renames getMemoryBehavior to computeMemoryBehavior and cleans some of the code that touches it. // I forgot to add this file in my previous commit.

Rename 'Threshold' to a more specific variable name.

00e1685

nadavrot added a commit that referenced this pull request Nov 23, 2015

Merge pull request #11 from nadavrot/alias_analysis_cleanups

cdacda9

Alias Analysis cleanups

nadavrot merged commit cdacda9 into swiftlang:master Nov 23, 2015

lattner mentioned this pull request Mar 29, 2016

[Parser] Cleans up parsing of function parameter attributes #1812

Merged

1 task

davezarzycki mentioned this pull request Mar 10, 2020

[semantic-arc-opts] Implement @owned phi web elimination for phi webs with a single phi node that only have copy_value introducers. #30289

Merged

dan-zheng mentioned this pull request Apr 3, 2020

[AutoDiff upstream] Add differentiation transform. #30781

Merged

efremale mentioned this pull request Jul 13, 2020

[AutoDiff][stdlib] Add JVPs to SIMDDifferentiation.swift.gyb #32854

Merged

slavapestov mentioned this pull request Jul 18, 2020

IRGen: Simplify logic for locating the legacy type info YAML file #32930

Merged

shahmishal mentioned this pull request Jul 18, 2020

[AutoDiff] Conform Optional to Differentiable. #32948

Merged

dfsweeney pushed a commit to dfsweeney/swift that referenced this pull request Sep 20, 2020

Merge pull request swiftlang#11 from minuscorp/typed-throws-dev

d638e48

Update typed throws implementation

maldahleh pushed a commit to maldahleh/swift that referenced this pull request Oct 26, 2020

Merge pull request swiftlang#11 from rintaro/lookuptable-custom

a997013

Use custom hash table as node lookup table

swift-ci mentioned this pull request Apr 6, 2016

[SR-815] Generic classes with default property initializers bug #43427

Closed

jopamer mentioned this pull request May 18, 2016

[SR-1551] Compilation stuck instead of failing on misspelt property name #44160

Closed

typesanitizer mentioned this pull request Nov 16, 2020

[SR-13852] Diagnostics calculates column numbers incorrectly for non-ASCII source lines #56250

Open

swift-ci mentioned this pull request Apr 25, 2022

[SR-15940] Assert crash in TypeCheckStmt.cpp #58201

Open

advancedwebdeveloper mentioned this pull request Aug 20, 2022

SourceLoc.h:251:1: error: too many template parameters in template redeclaration #60675

Open

This was referenced Oct 4, 2022

[SR-13243] Internal compiler error in AllocBoxToStack.cpp #55683

Closed

[SR-9291] SIGSEGV with large array in SILGen #51762

Closed

swift-ci mentioned this pull request Nov 20, 2022

[SR-10546] Runtime crash while iterating through collection of Decodable structs w/ URL fields #52946

Closed

finagolfin mentioned this pull request Sep 23, 2023

[SR-16046] A test from NIO segfaults on Android armv7 when cross-compiled with the official Swift 5.6 release for Ubuntu 20.04 x86_64 #58307

Closed

DougGregor pushed a commit to DougGregor/swift that referenced this pull request Apr 28, 2024

Merge pull request swiftlang#11 from compnerd/sdk-packaging-fixes

81e5817

Windows: correct some errors in the SDK manifest

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Alias analysis cleanups #11

Alias analysis cleanups #11

nadavrot commented Nov 23, 2015

nadavrot commented Nov 23, 2015

lattner commented Nov 23, 2015

nadavrot commented Nov 23, 2015

lattner commented Nov 23, 2015

tkremenek commented Nov 23, 2015

Alias analysis cleanups #11

Alias analysis cleanups #11

Conversation

nadavrot commented Nov 23, 2015

nadavrot commented Nov 23, 2015

lattner commented Nov 23, 2015

nadavrot commented Nov 23, 2015

lattner commented Nov 23, 2015

tkremenek commented Nov 23, 2015