Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use https instead of git@ for cloning instructions #29

Closed
wants to merge 1 commit into from
Closed

Use https instead of git@ for cloning instructions #29

wants to merge 1 commit into from

Conversation

kylef
Copy link

@kylef kylef commented Dec 3, 2015

Cloning with git@ uses SSH and thus requires the user to have an account on GitHub and have an SSH key locally configured and attached to their GitHub account.

Changing this to https removes these dependencies for users following instructions on the README.

This also updates links to ninja build repository and their new website.

@jorng
Copy link
Contributor

jorng commented Dec 3, 2015

This should really be two different requests. You've also included a URL change for Ninja

@BrandonMathis
Copy link
Contributor

Excellent suggestion! I've updated my own PR #31 to include this change

@alfwatt
Copy link

alfwatt commented Dec 3, 2015

+1

@glittershark
Copy link

why not git://?

@vamsi
Copy link

vamsi commented Dec 3, 2015

+1

@vocaro
Copy link

vocaro commented Dec 3, 2015

What about users who prefer SSH connections so that they don't have to enter a username and password every time they clone something?

@kylef
Copy link
Author

kylef commented Dec 3, 2015

@vocaro This is a public repository so you wouldn't need to enter a username or password.

@daknob
Copy link
Contributor

daknob commented Dec 3, 2015

+1 (:+1:)

@takebayashi
Copy link
Contributor

+1

@AquaGeek
Copy link
Contributor

AquaGeek commented Dec 3, 2015

I think you can configure your git settings to override it for you via insteadOf.

@Haroenv Haroenv mentioned this pull request Dec 4, 2015
@evieluvsrainbows
Copy link

This is really pointless. People should just create a GitHub account and SSH key. It takes less than 2 minutes to do so.

@kkirsche
Copy link

kkirsche commented Dec 4, 2015

@KamranMackey Swift, a project on Github, should follow Github's recommendations for method of cloning not user / your preference.

https://help.github.com/articles/which-remote-url-should-i-use/#cloning-with-https-recommended

@tkremenek
Copy link
Member

This is now resolved by 15428fb.

@tkremenek tkremenek closed this Dec 4, 2015
slavapestov pushed a commit to slavapestov/swift that referenced this pull request Nov 27, 2018
Initialise dispatch_queue_attr_concurrent on Linux
slavapestov pushed a commit to slavapestov/swift that referenced this pull request Nov 27, 2018
Initialise dispatch_queue_attr_concurrent on Linux

Signed-off-by: Daniel A. Steffen <dsteffen@apple.com>
DougGregor pushed a commit to DougGregor/swift that referenced this pull request Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.