Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable SourceKit tests if building SourceKit other than ubuntu 14.04 #9025

Merged
merged 2 commits into from
Apr 27, 2017

Conversation

norio-nomura
Copy link
Contributor

@norio-nomura norio-nomura commented Apr 26, 2017

Resolves SR-1676, SR-4490, SR-4491

@norio-nomura norio-nomura force-pushed the enable-sourcekit-test-on-linux branch from 25063e6 to 459c18d Compare April 26, 2017 23:44
@norio-nomura
Copy link
Contributor Author

norio-nomura commented Apr 26, 2017

Updated test/lit.cfg:

  • Add /usr/bin/lsb_release is executable
  • Remove codename that never used
  • Do not set LinuxDistribution=… if distributor or release is empty

Sorry, previous conversations are missing, since I did force push.

@alblue
Copy link
Contributor

alblue commented Apr 27, 2017

Looks good to me - let's see what happens with the tests, and if they pass, look at merging it in to trigger the 14.04 bots.
@swift-ci please smoke test

@alblue
Copy link
Contributor

alblue commented Apr 27, 2017

lit.py: /home/buildnode/disk2/workspace/swift-PR-Linux-smoke-test/branch-master/swift/test/lit.cfg:1102: note: Running tests on Ubuntu-16.04
lit.py: /home/buildnode/disk2/workspace/swift-PR-Linux-smoke-test/branch-master/swift/test/lit.cfg:1104: note: Available features: LinuxDistribution=Ubuntu-16.04, CODEGENERATOR=SystemZ, asan_runtime, SWIFT_VERSION=3, CODEGENERATOR=PowerPC, autolink-extract, swift_test_mode_optimize_none, swift_stdlib_no_asserts, swift_test_mode_optimize_none_x86_64, optimized_stdlib, no_lto, no_asan, tsan_runtime, lldb, CODEGENERATOR=X86, crash-recovery, CPU=x86_64, CODEGENERATOR=ARM, static_stdlib, CMAKE_GENERATOR=Ninja, optimized_stdlib_x86_64, swift-remoteast-test, nonexecutable_test, OS=linux-gnu, swift_interpreter, CODEGENERATOR=AArch64, CPU=i386_or_x86_64, ubsan_runtime, sourcekit, asserts, executable_test, PTRSIZE=64

Looks good :)

@alblue alblue merged commit 52a0043 into swiftlang:master Apr 27, 2017
@norio-nomura
Copy link
Contributor Author

Thanks! 😄

@norio-nomura norio-nomura deleted the enable-sourcekit-test-on-linux branch April 27, 2017 11:52
@alblue
Copy link
Contributor

alblue commented Apr 27, 2017

Seems to have done the trick; the 14.04 build succeeded with messages like:

UNSUPPORTED: Swift(linux-x86_64) :: SourceKit/SyntaxMapData/syntaxmap-edit.swift (7104 of 9697)
UNSUPPORTED: Swift(linux-x86_64) :: SourceKit/SyntaxMapData/syntaxmap.swift (7105 of 9697)
UNSUPPORTED: Swift(linux-x86_64) :: SourceKit/SyntaxMapData/syntaxmap-pound-keyword.swift (7106 of 9697)

The tests also ran correctly on the 16.04 bot:

PASS: Swift(linux-x86_64) :: SourceKit/SyntaxMapData/syntaxmap-pound-keyword.swift (7108 of 9697)
PASS: Swift(linux-x86_64) :: SourceKit/SyntaxMapData/syntaxmap-edit.swift (7113 of 9697)
PASS: Swift(linux-x86_64) :: SourceKit/SyntaxMapData/syntaxmap.swift (7114 of 9697)

However the 16.04 build failed with (what looks like) an unrelated issue:

Test Suite 'MiscellaneousTestCase' started at 06:53:47.979
Test Case 'MiscellaneousTestCase.testCanKillSubprocessOnSigInt' started at 06:53:47.979
/home/buildnode/jenkins/workspace/oss-swift-incremental-RA-linux-ubuntu-16_10/swiftpm/Tests/FunctionalTests/MiscellaneousTests.swift:465: error: MiscellaneousTestCase.testCanKillSubprocessOnSigInt : failed - Couldn't launch the process
Test Case 'MiscellaneousTestCase.testCanKillSubprocessOnSigInt' failed (2.979 seconds)
Test Suite 'MiscellaneousTestCase' failed at 06:53:50.958
	 Executed 1 test, with 1 failure (0 unexpected) in 2.979 (2.979) seconds
Test Suite 'Selected tests' failed at 06:53:50.958
	 Executed 1 test, with 1 failure (0 unexpected) in 2.979 (2.979) seconds--- bootstrap: error: tests failed with exit status 1

We should not revert this pull request because of the above failure, since it's unrelated. Maybe a subsequent build will work as expected.

@alblue
Copy link
Contributor

alblue commented Apr 27, 2017

NB the OSX build failed as well:

ninja: error: '/Users/buildnode/jenkins/workspace/oss-swift-incremental-RA-osx/swift/stdlib/public/SDK/CoreMedia/swiftXPC-swiftmodule-iphonesimulator-i386', needed by 'stdlib/public/SDK/CoreMedia/iphonesimulator/i386/CoreMedia.o', missing and no known rule to make it

The smoke test builds on both Linux and Darwin succeeded without these errors, and this same error has been reported since build 9701 yesterday evening:

https://ci.swift.org/job/oss-swift-incremental-RA-osx/9701/consoleFull#57226989ee1a197b-acac-4b17-83cf-a53b95139a76

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants