-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable SourceKit tests if building SourceKit other than ubuntu 14.04 #9025
Enable SourceKit tests if building SourceKit other than ubuntu 14.04 #9025
Conversation
This reverts commit a383adf.
25063e6
to
459c18d
Compare
Updated
Sorry, previous conversations are missing, since I did force push. |
Looks good to me - let's see what happens with the tests, and if they pass, look at merging it in to trigger the 14.04 bots. |
lit.py: /home/buildnode/disk2/workspace/swift-PR-Linux-smoke-test/branch-master/swift/test/lit.cfg:1102: note: Running tests on Ubuntu-16.04 Looks good :) |
Thanks! 😄 |
Seems to have done the trick; the 14.04 build succeeded with messages like:
The tests also ran correctly on the 16.04 bot:
However the 16.04 build failed with (what looks like) an unrelated issue:
We should not revert this pull request because of the above failure, since it's unrelated. Maybe a subsequent build will work as expected. |
NB the OSX build failed as well:
The smoke test builds on both Linux and Darwin succeeded without these errors, and this same error has been reported since build 9701 yesterday evening: |
Resolves SR-1676, SR-4490, SR-4491