Skip to content
This repository has been archived by the owner on Nov 17, 2021. It is now read-only.
This repository has been archived by the owner on Nov 17, 2021. It is now read-only.

Switch from mcrypt to more secure implementation #634

Closed
Hikariii opened this issue Jul 7, 2015 · 1 comment
Closed

Switch from mcrypt to more secure implementation #634

Hikariii opened this issue Jul 7, 2015 · 1 comment

Comments

@Hikariii
Copy link

Hikariii commented Jul 7, 2015

libmcrypt is a dead project, unmaintained for ~8 years, last version 2.5.8 was released in February 2007!
Various well maintained alternative libraries exist:

  • openssl
  • nss (Network Security Service)
  • etc.

See also http://blog.remirepo.net/post/2015/07/07/About-libmcrypt-and-php-mcrypt
@xdecock
Copy link
Member

xdecock commented Jul 7, 2015

You can probably propose a pull request easily as it's seems to only affect

lib/classes/Swift/Transport/Esmtp/Auth/NTLMAuthenticator.php and the
related test.

I don't use it so not sure i won't mess up everything.

On Tue, Jul 7, 2015 at 10:11 AM, Sebastiaan de Rooij <
notifications@github.com> wrote:

libmcrypt is a dead project, unmaintained for ~8 years, last version 2.5.8
was released in February 2007!
Various well maintained alternative libraries exist:

  • openssl
  • nss (Network Security Service)
  • etc.

See also
http://blog.remirepo.net/post/2015/07/07/About-libmcrypt-and-php-mcrypt

—
Reply to this email directly or view it on GitHub
#634.

Xavier De Cock
GPG Fingerprint: 93CA EE3F 9F57 5BE1 AE4A 794D 3C74 CA9E E7A5 0C1B
GPG Id: 0xE7A50C1B

@c960657 c960657 mentioned this issue May 7, 2016
Merged
fabpot added a commit that referenced this issue Jul 8, 2016
@fabpot
bug #757 Use OpenSSL instead of mcrypt (c960657)
2d3f75a 
This PR was merged into the 5.x branch.

Discussion
----------

Use OpenSSL instead of mcrypt

Fix for #634.

I haven't tested this with an actual NTLM server, but the unit test still passes. Inspired by https://github.com/robinpowered/php-ntlm/tree/master/src/Robin/Ntlm/Crypt/Des.

Commits
-------

92334ab Use OpenSSL instead of mcrypt
@fabpot fabpot closed this as completed Jul 8, 2016
makasim pushed a commit to formapro-forks/swiftmailer that referenced this issue Jul 26, 2017
@Seldaek
Merge pull request swiftmailer#634 from henriquemoody/resource_type
841ecbe 
Better normalization for resources
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fabpot @xdecock @Hikariii