Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cosmological scale factor conversion #33

Closed
JBorrow opened this issue Feb 10, 2020 · 1 comment
Closed

Cosmological scale factor conversion #33

JBorrow opened this issue Feb 10, 2020 · 1 comment
Labels
bug Something isn't working enhancement New feature or request

Comments

@JBorrow
Copy link
Member

JBorrow commented Feb 10, 2020

We used to have a method to_physical() on datasets; this had to be removed because it was really buggy.

We currently deal with this in the following way: https://swiftsimio.readthedocs.io/en/latest/loading_data/index.html#non-unyt-properties but it would be nice to have a cleaner solution.
@JBorrow JBorrow added bug Something isn't working enhancement New feature or request labels Feb 10, 2020
@JBorrow
Copy link
Member Author

JBorrow commented Mar 8, 2020

Fixed in #36

@JBorrow JBorrow closed this as completed Mar 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JBorrow