Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatic performance testing #67

Closed
j-f1 opened this issue Sep 21, 2020 · 2 comments · Fixed by #68
Closed

Automatic performance testing #67

j-f1 opened this issue Sep 21, 2020 · 2 comments · Fixed by #68
Assignees
@j-f1
Labels
enhancement New feature or request

Comments

@j-f1
Copy link
Member

j-f1 commented Sep 21, 2020

I’ve seen repositories before that have a bot post a comment on all new PRs with a comparison of the perf tests between main and the PR branch. This would be very nice to have so we don’t accidentally introduce regressions, and to celebrate perf improvements when they’re added.
@j-f1 j-f1 added the enhancement New feature or request label Sep 21, 2020
@j-f1
Copy link
Member Author

j-f1 commented Sep 21, 2020

Here’s an action that could probably be adapted to measure perf instead of bundle size: https://github.com/preactjs/compressed-size-action/blob/master/src/index.js

@j-f1 j-f1 self-assigned this Sep 21, 2020
@j-f1 j-f1 linked a pull request Sep 21, 2020 that will close this issue
Add perf testing #68
Merged
@MaxDesiatov
Copy link
Contributor

Can this be considered resolved now?

@j-f1 j-f1 closed this as completed Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@j-f1 j-f1

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add perf testing swiftwasm/JavaScriptKit
2 participants
@MaxDesiatov @j-f1