Merge Guile 2.0 support into master #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In other words guilescm becomes guile. Deprecated gh api tests are moved to guilegh.
Note: only the scm interface is considered.
Note: guile-config is badly broken for guile 2. So the guile configure section has been rewritten to use pkg-config instead. Manually resolved conflicts: Examples/Makefile.in
All of guile's interface files now use the scm interface. This should not affect any users. Swig generated code using the scm interface can be mixed with gh interface using user code. It does simplify maintenance of the guile swig code though.
On 19/04/13 18:41, Geert Janssens wrote: > Hi, > > I'm working through the failing testcases for guile. One testcase fails > with a compilation error in some generated code based on std_map and > std_pair. I know exactly where this generated code comes from, but my > C++ knowledge is insufficient to understand the error, let alone remedy > it. I gather some kind of const violation, but that's all I can read > from it :( My hope is that someone used to working with stl will more > easily understand it. > > So, if someone can help me understand the error and what the fix would > be in C++, I can fix the corresponding .i file. > > This is the code snippet the causes the error: > <snip> > > /usr/lib/gcc/i686-redhat-linux/4.7.2/../../../../include/c++/4.7.2/bits/stl_pair.h:88:12: > error: non-static const member ‘const std::pair<int, A*> std::pair<int, > const std::pair<int, A*> >::second’, can’t use default assignment operator This is the main problem - it is saying there is no default assignment operator (because one of the members in pair is const). The solution is to avoid assignment. I've attached a patch to do this plus some error message corrections. William
Autocompilation generates a lot of warnings. Most of them just informational, but it clutters the test output.
- add missing library in link phase - empty true path () for if is not allowed
- fix compiler warning - fix guile 2 deprecation warnings - minor cleanup of generated code
|
Thank you, Geert Janssens and William S Fulton, for updating SWIG for Guile 2.0. It's much appreciated by me and others in #guile at irc.freenode.net. Any chance directors may be coming down the pike? |
|
Sorry, but I havn't heard of anyone planning on implementing this. |
|
I currently have no more spare time available to work on guile support in swig. So I won't be the one to implement this, sorry. |
|
No need to apologize. My compliments to you both again for this excellent patch. I may take up the charge in integrating directors myself. We shall see. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This series of commits will