Add new but ignored warning option -Wdate-time. #511
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rationale: This would be helpful for the Debian reproducible builds effort, described at https://wiki.debian.org/ReproducibleBuilds Basically, the warning is used to detect where the time macros __TIME__, __DATE__ etc. are used, but this makes SWIG fail because of the unrecognized option.
|
@ojwb, Agreed, but this is a non-ideal but pragmatic change, see the swig-devel discussion on this at http://thread.gmane.org/gmane.comp.programming.swig.devel/23717. Could you respond to that discussion. Also, as you know Debian quite well, perhaps you can guide the appropriate project to sort it out properly? |
|
I'd be much more sold on a wrong but pragmatic change if there were many affected packages, but only two have been mentioned so far. So to me, the appropriate fix seems to be patching the build systems of the Debian subversion and unbound packages to not do Will follow up in that thread. |
|
Done. |
|
Closing this pull request, I concur with Ollys arguments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale: This would be helpful for the Debian reproducible builds
effort, described at https://wiki.debian.org/ReproducibleBuilds
Basically, the warning is used to detect where the time macros
__TIME__,__DATE__etc. are used, but this makes SWIG fail becauseof the unrecognized option.
Please see my email on swig-devel and this feature request for more background.