Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

broken anonymous sessions from #1874 #1878

Closed
leafty opened this issue May 16, 2024 · 0 comments · Fixed by #1879
Closed

broken anonymous sessions from #1874 #1878

leafty opened this issue May 16, 2024 · 0 comments · Fixed by #1879

Comments

@leafty
Copy link
Member

leafty commented May 16, 2024 •
edited
Loading

Introduced in #1874:

renku-notebooks/renku_notebooks/api/classes/data_service.py

Lines 267 to 275 in 2adec8d

providers_list.insert(
0,
GitProvider(
id=INTERNAL_GITLAB_PROVIDER,
url=self.internal_gitlab_url,
connection_id="",
access_token_url=internal_gitlab_access_token_url,
),
)

The internal gitlab provider should not be set up for anonymous sessions (crashes the git clone container).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: do not setup any git provider for anonymous sessions SwissDataScienceCenter/renku-notebooks
1 participant
@leafty