Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple ports per container #84

Closed
fredericbirke opened this issue Feb 15, 2021 · 3 comments
Closed

Allow multiple ports per container #84

fredericbirke opened this issue Feb 15, 2021 · 3 comments

Comments

@fredericbirke
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Docker allows you to spin up a container and expose multiple port settings on it. As far as I can see, the ContainerResourceBuilder only allows for one port to be mapped.
Concrete example where this is useful:
VerneMq Mqtt exposes port 1883 for connections, but also 8888 for exposing health checks and metrics.

Describe the solution you'd like
Allow multiple port mappings per container by adapting the api of ContainerResourceBuilder ports to the same approach as cmds, volumes and env vars.

@philbir
Copy link
Member

philbir commented Feb 15, 2021

Yes, today it's only possible to add one port mapping. I see the point that it could be usefull to expose multiple ports.
We'll check the option to allow to map multiple ports in a future release.

@fredericbirke
Copy link
Contributor Author

I added a PR, that adds this feature:
#88

@Carael
Copy link
Contributor

Carael commented Feb 1, 2022

PR merged into master

@Carael Carael closed this as completed Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants