fix: add italic defintion to fonts.scss #1513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannikstuker
requested review from
gfellerph,
oliverschuerch and
alizedebray
as code owners
🦋 Changeset detectedLatest commit: 52e7541 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Preview environment ready: https://preview-1513--swisspost-web-frontend.netlify.app |
yannikstuker
force-pushed
the
926-Provide-italic-font-variants
branch
from
8e5c3ab
to
834ec69
Compare
|
It was not intentional to delete the variable, I readded them |
gfellerph
added
the
open-source-day-june-2023
gfellerph
approved these changes
Jun 15, 2023
|
@yannikstuker thank you for contributing! |
|
Kudos, SonarCloud Quality Gate passed!
|
alizedebray
added a commit
that referenced
this pull request
Jun 20, 2023
* feat(docs): use post-icon component in button stories * feat(docs): use post-icon component in card stories * feat(docs): use post-icon component in table stories * feat(docs): use post-icon component in toast stories * feat(docs): use post-icon component in alert stories * feat(docs): add changeset * docs: update migration guide with precise installation instructions (#1473) * fix: sonar bugs and code smells (#1471) * chore(icons): ☝️ update icons (#1487) * feat(documentation): add styles getting started page (#1468) * chore(deps): update all non-major dependencies (#1489) * feat(styles): use @swisspost/design-system-icons (#1418) * feat(styles): add custom function to SASS compiler that compute inline SVGs from @swisspost/design-system-icons * feat(styles): fix linting issues * feat(styles): fix unofficial icons * feat(styles): limit .pi-* classes to those that already exist * feat(styles): do not ignore svg-icon-map.scss * feat(styles): fix icon 2184 * fix(stlyes): alert action buttons for alerts (#1495) Error only appeared on the storybook visual regression testing page. * fix(styles): override bootstrap focus styles (#1496) * fix(demo): add href to make link focusable (#1497) Stepper links make no sense without being a link back to this step. A href or [routerLink] is needed anyways. Regression was added because of https://github.com/swisspost/design-system/pull/1317/files#r1153405992. A href attribute might be less missleading than an internal [routerLink]. * chore: update icon fetching process to generate icon-map (#1499) * chore: create devcontainer.json (#1484) Enables codespaces with the node feature enabled. Codespaces can be used to create a dev environment in the browser or in a docker container. * refactor(components): change post icon loading mechanism (#1485) * chore(documentation): reorganize storybook navigation (#1444) * feat(demo): update versions.json (#1502) * chore: updated test path for internet header tests and removed obsolete changeset (#1506) * feat(styles): update tooltips position (#1505) * feat(documentation): add background utilities stories (#1438) Co-authored-by: Alizé Debray <33580481+alizedebray@users.noreply.github.com> Co-authored-by: Philipp Gfeller <1659006+gfellerph@users.noreply.github.com> * chore(changesets): publish packages (#1417) * chore(devcontainer): Update to pnpm v8 (#1511) * chore(devcontainer): set cpu&mem requirements for codespaces (#1519) * chore(devcontainer): Set min host requirement for codespaces * chore(devcontainer): reduce required cpus to 4 * chore: update splash screen with new swiss post logo (#1520) * feat(styles): add placeholder to floating label inputs (#1509) * feat(documentation): add getting started components stories (#1518) * fix(internet-header): fix klp-login-widget focus (#1476) * fix(header): add 1px to stickyness-minimal #1156 (#1517) * fix: add italic defintion to fonts.scss (#1513) * fix(docs): update defineCustomElements import statement (#1530) * chore: update all storybook links (#1514) * chore: update all storybook links * chore: fix collapsible tests * add changeset * feat(documentation): include new icons getting started page (#1531) The svg `use` tag is NOT working with the cdn approch so far, because of the crossorigin policy: https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/crossorigin --------- Co-authored-by: Alizé Debray <33580481+alizedebray@users.noreply.github.com> Co-authored-by: Philipp Gfeller <1659006+gfellerph@users.noreply.github.com> * fix(demo): update the link to the internet-header documentation (#1528) * chore(changesets): publish packages (#1523) * feat(docs): add a hint for alert icons --------- Co-authored-by: Philipp Gfeller <1659006+gfellerph@users.noreply.github.com> Co-authored-by: Oliver Schürch <oliver.schuerch@post.ch> Co-authored-by: Swiss Post Devs <103635272+swisspost-devs@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: p45q <p45q89@gmail.com> Co-authored-by: Stef Chäser <info.stef.kaeser@gmail.com> Co-authored-by: cellcoresystems <cellcore.systems@gmail.com> Co-authored-by: Yannik Stuker <yannik.stuker@gmail.com>
alizedebray
added a commit
that referenced
this pull request
Jun 20, 2023
* feat(demo): set-up post-icon component in demo app * feat(demo): use post-icon component in buttons * feat(demo): use post-icon component in cards * feat(demo): use post-icon component in notifications * feat(demo): use post-icon component in intranet-header * feat(demo): use post-icon component in dropdowns * feat(demo): use post-icon component in ngb-alerts * feat(demo): use post-icon component in datepicker * feat(demo): use post-icon component in custom select * feat(demo): use post-icon component in product cards * feat(demo): use post-icon component in notification overlay * feat(demo): use post-icon component in datatable * feat(demo): fix alerts on smaller screens * feat(demo): update lock file * feat(styles): add changeset files * feat(docs): use the post-icon component in the documentation (#1474) * feat(docs): use post-icon component in button stories * feat(docs): use post-icon component in card stories * feat(docs): use post-icon component in table stories * feat(docs): use post-icon component in toast stories * feat(docs): use post-icon component in alert stories * feat(docs): add changeset * docs: update migration guide with precise installation instructions (#1473) * fix: sonar bugs and code smells (#1471) * chore(icons): ☝️ update icons (#1487) * feat(documentation): add styles getting started page (#1468) * chore(deps): update all non-major dependencies (#1489) * feat(styles): use @swisspost/design-system-icons (#1418) * feat(styles): add custom function to SASS compiler that compute inline SVGs from @swisspost/design-system-icons * feat(styles): fix linting issues * feat(styles): fix unofficial icons * feat(styles): limit .pi-* classes to those that already exist * feat(styles): do not ignore svg-icon-map.scss * feat(styles): fix icon 2184 * fix(stlyes): alert action buttons for alerts (#1495) Error only appeared on the storybook visual regression testing page. * fix(styles): override bootstrap focus styles (#1496) * fix(demo): add href to make link focusable (#1497) Stepper links make no sense without being a link back to this step. A href or [routerLink] is needed anyways. Regression was added because of https://github.com/swisspost/design-system/pull/1317/files#r1153405992. A href attribute might be less missleading than an internal [routerLink]. * chore: update icon fetching process to generate icon-map (#1499) * chore: create devcontainer.json (#1484) Enables codespaces with the node feature enabled. Codespaces can be used to create a dev environment in the browser or in a docker container. * refactor(components): change post icon loading mechanism (#1485) * chore(documentation): reorganize storybook navigation (#1444) * feat(demo): update versions.json (#1502) * chore: updated test path for internet header tests and removed obsolete changeset (#1506) * feat(styles): update tooltips position (#1505) * feat(documentation): add background utilities stories (#1438) Co-authored-by: Alizé Debray <33580481+alizedebray@users.noreply.github.com> Co-authored-by: Philipp Gfeller <1659006+gfellerph@users.noreply.github.com> * chore(changesets): publish packages (#1417) * chore(devcontainer): Update to pnpm v8 (#1511) * chore(devcontainer): set cpu&mem requirements for codespaces (#1519) * chore(devcontainer): Set min host requirement for codespaces * chore(devcontainer): reduce required cpus to 4 * chore: update splash screen with new swiss post logo (#1520) * feat(styles): add placeholder to floating label inputs (#1509) * feat(documentation): add getting started components stories (#1518) * fix(internet-header): fix klp-login-widget focus (#1476) * fix(header): add 1px to stickyness-minimal #1156 (#1517) * fix: add italic defintion to fonts.scss (#1513) * fix(docs): update defineCustomElements import statement (#1530) * chore: update all storybook links (#1514) * chore: update all storybook links * chore: fix collapsible tests * add changeset * feat(documentation): include new icons getting started page (#1531) The svg `use` tag is NOT working with the cdn approch so far, because of the crossorigin policy: https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/crossorigin --------- Co-authored-by: Alizé Debray <33580481+alizedebray@users.noreply.github.com> Co-authored-by: Philipp Gfeller <1659006+gfellerph@users.noreply.github.com> * fix(demo): update the link to the internet-header documentation (#1528) * chore(changesets): publish packages (#1523) * feat(docs): add a hint for alert icons --------- Co-authored-by: Philipp Gfeller <1659006+gfellerph@users.noreply.github.com> Co-authored-by: Oliver Schürch <oliver.schuerch@post.ch> Co-authored-by: Swiss Post Devs <103635272+swisspost-devs@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: p45q <p45q89@gmail.com> Co-authored-by: Stef Chäser <info.stef.kaeser@gmail.com> Co-authored-by: cellcoresystems <cellcore.systems@gmail.com> Co-authored-by: Yannik Stuker <yannik.stuker@gmail.com> * revert changes to the demo app * Update icon size in documentation icons --------- Co-authored-by: Philipp Gfeller <1659006+gfellerph@users.noreply.github.com> Co-authored-by: Oliver Schürch <oliver.schuerch@post.ch> Co-authored-by: Swiss Post Devs <103635272+swisspost-devs@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: p45q <p45q89@gmail.com> Co-authored-by: Stef Chäser <info.stef.kaeser@gmail.com> Co-authored-by: cellcoresystems <cellcore.systems@gmail.com> Co-authored-by: Yannik Stuker <yannik.stuker@gmail.com>
gfellerph
added a commit
that referenced
this pull request
Jun 29, 2023
* feat(demo): set-up post-icon component in demo app * feat(demo): use post-icon component in buttons * feat(demo): use post-icon component in cards * feat(demo): use post-icon component in notifications * feat(demo): use post-icon component in intranet-header * feat(demo): use post-icon component in dropdowns * feat(demo): use post-icon component in ngb-alerts * feat(demo): use post-icon component in datepicker * feat(demo): use post-icon component in custom select * feat(demo): use post-icon component in product cards * feat(demo): use post-icon component in notification overlay * feat(demo): use post-icon component in datatable * feat(demo): fix alerts on smaller screens * feat(demo): update lock file * feat(styles): add changeset files * feat(docs): use the post-icon component in the documentation (#1474) * feat(docs): use post-icon component in button stories * feat(docs): use post-icon component in card stories * feat(docs): use post-icon component in table stories * feat(docs): use post-icon component in toast stories * feat(docs): use post-icon component in alert stories * feat(docs): add changeset * docs: update migration guide with precise installation instructions (#1473) * fix: sonar bugs and code smells (#1471) * chore(icons): ☝️ update icons (#1487) * feat(documentation): add styles getting started page (#1468) * chore(deps): update all non-major dependencies (#1489) * feat(styles): use @swisspost/design-system-icons (#1418) * feat(styles): add custom function to SASS compiler that compute inline SVGs from @swisspost/design-system-icons * feat(styles): fix linting issues * feat(styles): fix unofficial icons * feat(styles): limit .pi-* classes to those that already exist * feat(styles): do not ignore svg-icon-map.scss * feat(styles): fix icon 2184 * fix(stlyes): alert action buttons for alerts (#1495) Error only appeared on the storybook visual regression testing page. * fix(styles): override bootstrap focus styles (#1496) * fix(demo): add href to make link focusable (#1497) Stepper links make no sense without being a link back to this step. A href or [routerLink] is needed anyways. Regression was added because of https://github.com/swisspost/design-system/pull/1317/files#r1153405992. A href attribute might be less missleading than an internal [routerLink]. * chore: update icon fetching process to generate icon-map (#1499) * chore: create devcontainer.json (#1484) Enables codespaces with the node feature enabled. Codespaces can be used to create a dev environment in the browser or in a docker container. * refactor(components): change post icon loading mechanism (#1485) * chore(documentation): reorganize storybook navigation (#1444) * feat(demo): update versions.json (#1502) * chore: updated test path for internet header tests and removed obsolete changeset (#1506) * feat(styles): update tooltips position (#1505) * feat(documentation): add background utilities stories (#1438) Co-authored-by: Alizé Debray <33580481+alizedebray@users.noreply.github.com> * chore(changesets): publish packages (#1417) * chore(devcontainer): Update to pnpm v8 (#1511) * chore(devcontainer): set cpu&mem requirements for codespaces (#1519) * chore(devcontainer): Set min host requirement for codespaces * chore(devcontainer): reduce required cpus to 4 * chore: update splash screen with new swiss post logo (#1520) * feat(styles): add placeholder to floating label inputs (#1509) * feat(documentation): add getting started components stories (#1518) * fix(internet-header): fix klp-login-widget focus (#1476) * fix(header): add 1px to stickyness-minimal #1156 (#1517) * fix: add italic defintion to fonts.scss (#1513) * fix(docs): update defineCustomElements import statement (#1530) * chore: update all storybook links (#1514) * chore: update all storybook links * chore: fix collapsible tests * add changeset * feat(documentation): include new icons getting started page (#1531) The svg `use` tag is NOT working with the cdn approch so far, because of the crossorigin policy: https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/crossorigin --------- Co-authored-by: Alizé Debray <33580481+alizedebray@users.noreply.github.com> Co-authored-by: Philipp Gfeller <1659006+gfellerph@users.noreply.github.com> * fix(demo): update the link to the internet-header documentation (#1528) * chore(changesets): publish packages (#1523) * feat(docs): add a hint for alert icons --------- Co-authored-by: Philipp Gfeller <1659006+gfellerph@users.noreply.github.com> * revert changes to the demo app * Update icon size in documentation icons --------- Co-authored-by: Philipp Gfeller <1659006+gfellerph@users.noreply.github.com> Co-authored-by: Oliver Schürch <oliver.schuerch@post.ch> Co-authored-by: Swiss Post Devs <103635272+swisspost-devs@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: p45q <p45q89@gmail.com> Co-authored-by: Stef Chäser <info.stef.kaeser@gmail.com> Co-authored-by: cellcoresystems <cellcore.systems@gmail.com> Co-authored-by: Yannik Stuker <yannik.stuker@gmail.com> feat(styles): use mask-image instead of background-image for icons (#1419) * feat(styles): add all icons form @swisspost/design-system-icons as assets to the style package * feat(styles): replace the pi() mixin with the icon() mixin which uses the asset icons * feat(styles): replace the get-colored-svg-url() function with the icon() mixin * feat(styles): refactor form-check styles to use the new icon() directive * feat(styles): refactor form-feedback styles to use the new icon() directive * feat(styles): add custom function to SASS compiler that compute inline SVGs from @swisspost/design-system-icons * feat(styles): use inline icons instead of assets * feat(styles): fix linting issues * feat(styles): fix linting issues * feat(styles): add changeset * feat(styles): fix unofficial icons * feat(styles): reuse same icon when possible * feat(styles): limit .pi-* classes to those that already exist * feat(styles): do not ignore svg-icon-map.scss * feat(styles): fix icon 2184 * feat(styles): fix icon 2184 * feat(styles): add correct focus shadow on check-inputs * feat(styles): fix hover color of the close button on dark backgrounds * feat(styles): fix button groups * feat(styles): update the color of the checkbox focus shadow on dark backgrounds Co-Authored-By: Philipp Gfeller <1659006+gfellerph@users.noreply.github.com> Co-Authored-By: Oliver Schürch <oliver.schuerch@post.ch> Co-Authored-By: Swiss Post Devs <103635272+swisspost-devs@users.noreply.github.com> Co-Authored-By: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-Authored-By: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-Authored-By: p45q <p45q89@gmail.com> Co-Authored-By: Stef Chäser <info.stef.kaeser@gmail.com> Co-Authored-By: cellcoresystems <cellcore.systems@gmail.com> Co-Authored-By: Yannik Stuker <yannik.stuker@gmail.com>
gfellerph
added a commit
that referenced
this pull request
Jun 29, 2023
* feat(demo): set-up post-icon component in demo app * feat(demo): use post-icon component in buttons * feat(demo): use post-icon component in cards * feat(demo): use post-icon component in notifications * feat(demo): use post-icon component in intranet-header * feat(demo): use post-icon component in dropdowns * feat(demo): use post-icon component in ngb-alerts * feat(demo): use post-icon component in datepicker * feat(demo): use post-icon component in custom select * feat(demo): use post-icon component in product cards * feat(demo): use post-icon component in notification overlay * feat(demo): use post-icon component in datatable * feat(demo): fix alerts on smaller screens * feat(demo): update lock file * feat(styles): add changeset files * feat(docs): use the post-icon component in the documentation (#1474) * feat(docs): use post-icon component in button stories * feat(docs): use post-icon component in card stories * feat(docs): use post-icon component in table stories * feat(docs): use post-icon component in toast stories * feat(docs): use post-icon component in alert stories * feat(docs): add changeset * docs: update migration guide with precise installation instructions (#1473) * fix: sonar bugs and code smells (#1471) * chore(icons): ☝️ update icons (#1487) * feat(documentation): add styles getting started page (#1468) * chore(deps): update all non-major dependencies (#1489) * feat(styles): use @swisspost/design-system-icons (#1418) * feat(styles): add custom function to SASS compiler that compute inline SVGs from @swisspost/design-system-icons * feat(styles): fix linting issues * feat(styles): fix unofficial icons * feat(styles): limit .pi-* classes to those that already exist * feat(styles): do not ignore svg-icon-map.scss * feat(styles): fix icon 2184 * fix(stlyes): alert action buttons for alerts (#1495) Error only appeared on the storybook visual regression testing page. * fix(styles): override bootstrap focus styles (#1496) * fix(demo): add href to make link focusable (#1497) Stepper links make no sense without being a link back to this step. A href or [routerLink] is needed anyways. Regression was added because of https://github.com/swisspost/design-system/pull/1317/files#r1153405992. A href attribute might be less missleading than an internal [routerLink]. * chore: update icon fetching process to generate icon-map (#1499) * chore: create devcontainer.json (#1484) Enables codespaces with the node feature enabled. Codespaces can be used to create a dev environment in the browser or in a docker container. * refactor(components): change post icon loading mechanism (#1485) * chore(documentation): reorganize storybook navigation (#1444) * feat(demo): update versions.json (#1502) * chore: updated test path for internet header tests and removed obsolete changeset (#1506) * feat(styles): update tooltips position (#1505) * feat(documentation): add background utilities stories (#1438) Co-authored-by: Alizé Debray <33580481+alizedebray@users.noreply.github.com> * chore(changesets): publish packages (#1417) * chore(devcontainer): Update to pnpm v8 (#1511) * chore(devcontainer): set cpu&mem requirements for codespaces (#1519) * chore(devcontainer): Set min host requirement for codespaces * chore(devcontainer): reduce required cpus to 4 * chore: update splash screen with new swiss post logo (#1520) * feat(styles): add placeholder to floating label inputs (#1509) * feat(documentation): add getting started components stories (#1518) * fix(internet-header): fix klp-login-widget focus (#1476) * fix(header): add 1px to stickyness-minimal #1156 (#1517) * fix: add italic defintion to fonts.scss (#1513) * fix(docs): update defineCustomElements import statement (#1530) * chore: update all storybook links (#1514) * chore: update all storybook links * chore: fix collapsible tests * add changeset * feat(documentation): include new icons getting started page (#1531) The svg `use` tag is NOT working with the cdn approch so far, because of the crossorigin policy: https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/crossorigin --------- Co-authored-by: Alizé Debray <33580481+alizedebray@users.noreply.github.com> Co-authored-by: Philipp Gfeller <1659006+gfellerph@users.noreply.github.com> * fix(demo): update the link to the internet-header documentation (#1528) * chore(changesets): publish packages (#1523) * feat(docs): add a hint for alert icons --------- Co-authored-by: Philipp Gfeller <1659006+gfellerph@users.noreply.github.com> * revert changes to the demo app * Update icon size in documentation icons --------- Co-authored-by: Philipp Gfeller <1659006+gfellerph@users.noreply.github.com> Co-authored-by: Oliver Schürch <oliver.schuerch@post.ch> Co-authored-by: Swiss Post Devs <103635272+swisspost-devs@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: p45q <p45q89@gmail.com> Co-authored-by: Stef Chäser <info.stef.kaeser@gmail.com> Co-authored-by: cellcoresystems <cellcore.systems@gmail.com> Co-authored-by: Yannik Stuker <yannik.stuker@gmail.com> feat(styles): use mask-image instead of background-image for icons (#1419) * feat(styles): add all icons form @swisspost/design-system-icons as assets to the style package * feat(styles): replace the pi() mixin with the icon() mixin which uses the asset icons * feat(styles): replace the get-colored-svg-url() function with the icon() mixin * feat(styles): refactor form-check styles to use the new icon() directive * feat(styles): refactor form-feedback styles to use the new icon() directive * feat(styles): add custom function to SASS compiler that compute inline SVGs from @swisspost/design-system-icons * feat(styles): use inline icons instead of assets * feat(styles): fix linting issues * feat(styles): fix linting issues * feat(styles): add changeset * feat(styles): fix unofficial icons * feat(styles): reuse same icon when possible * feat(styles): limit .pi-* classes to those that already exist * feat(styles): do not ignore svg-icon-map.scss * feat(styles): fix icon 2184 * feat(styles): fix icon 2184 * feat(styles): add correct focus shadow on check-inputs * feat(styles): fix hover color of the close button on dark backgrounds * feat(styles): fix button groups * feat(styles): update the color of the checkbox focus shadow on dark backgrounds Co-Authored-By: Philipp Gfeller <1659006+gfellerph@users.noreply.github.com> Co-Authored-By: Oliver Schürch <oliver.schuerch@post.ch> Co-Authored-By: Swiss Post Devs <103635272+swisspost-devs@users.noreply.github.com> Co-Authored-By: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-Authored-By: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-Authored-By: p45q <p45q89@gmail.com> Co-Authored-By: Stef Chäser <info.stef.kaeser@gmail.com> Co-Authored-By: cellcoresystems <cellcore.systems@gmail.com> Co-Authored-By: Yannik Stuker <yannik.stuker@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.