Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tabs): include hcm styles for tabs #252

Merged
merged 10 commits into from
Aug 11, 2022
Merged

fix(tabs): include hcm styles for tabs #252

merged 10 commits into from
Aug 11, 2022

Conversation

oliverschuerch
Copy link
Contributor

No description provided.

…round mixin

So components can ad styles, if there is set a background-class on any parent element
Levels up the tab-title specificity, so nav-item styles do not overwrite color, etc.
Gets rid of @supports media-query, because it's no longer needed
@oliverschuerch oliverschuerch linked an issue Aug 3, 2022 that may be closed by this pull request
3 tasks
@changeset-bot
Copy link

changeset-bot bot commented Aug 3, 2022

🦋 Changeset detected

Latest commit: 7831c97

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@swisspost/web-styles Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2022

🚀 Preview environment ready: https://preview-252--swisspost-web-frontend.netlify.app

@oliverschuerch oliverschuerch marked this pull request as ready for review August 3, 2022 13:44
# Conflicts:
#	packages/web-styles/src/components/tabs.scss
.changeset/dirty-jokes-divide.md Outdated Show resolved Hide resolved
packages/web-styles/src/mixins/_color.scss Outdated Show resolved Hide resolved
packages/web-styles/src/variables/_color.scss Outdated Show resolved Hide resolved
oliverschuerch and others added 2 commits August 11, 2022 08:50
Co-authored-by: Philipp Gfeller <1659006+gfellerph@users.noreply.github.com>
@sonarcloud
Copy link

sonarcloud bot commented Aug 11, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HCM: Tabs
2 participants