Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing frames in subsequent marker messages not handled correctly. #265

Closed
malban opened this issue Nov 14, 2015 · 1 comment
Closed

Changing frames in subsequent marker messages not handled correctly. #265

malban opened this issue Nov 14, 2015 · 1 comment
Assignees
@pjreed
Labels
bug

Comments

@malban
Copy link
Contributor

malban commented Nov 14, 2015

Changing frames in subsequent marker messages not handled correctly.

The data appears to be displayed as if it was with respect to the frame of the first message.
@malban malban added the bug label Nov 14, 2015
@pjreed
Copy link
Contributor

pjreed commented Apr 7, 2016

I looked into this, and the cause is pretty obvious; the plugin sets its source_frame_ member variable the first time a message is received, and mapviz uses that to transform the contents, and its value is never changed again unless you change the topic name.

It looks like there are actually several plugins that have this same behavior, so I'll fix all of them at once.

@pjreed pjreed self-assigned this Apr 7, 2016
pjreed added a commit to pjreed/mapviz that referenced this issue Apr 7, 2016
@pjreed
Fix for swri-robotics#265; message source frames don't update
7094c59 
Several plugins were storing the source frames of messages received when
they first received a message but never updating them, so subsequent
messages in different frames would be rendered incorrectly.
pjreed added a commit to pjreed/mapviz that referenced this issue Apr 7, 2016
@pjreed
Fix for swri-robotics#265; message source frames don't update
3db6c77 
Several plugins were storing the source frames of messages received when
they first received a message but never updating them, so subsequent
messages in different frames would be rendered incorrectly.
pjreed added a commit to pjreed/mapviz that referenced this issue Apr 11, 2016
@pjreed
Fix for swri-robotics#265; message source frames don't update
05532c8 
Several plugins were storing the source frames of messages received when
they first received a message but never updating them, so subsequent
messages in different frames would be rendered incorrectly.
pjreed added a commit to pjreed/mapviz that referenced this issue Apr 11, 2016
@pjreed
Fix for swri-robotics#265; message source frames don't update
47c8b0c 
Several plugins were storing the source frames of messages received when
they first received a message but never updating them, so subsequent
messages in different frames would be rendered incorrectly.
evenator added a commit that referenced this issue Apr 11, 2016
@evenator
Merge pull request #335 from pjreed/265-plugin-source-frames-jade
54fa563 
Fix for #265; message source frames don't update (Jade)
evenator added a commit that referenced this issue Apr 11, 2016
@evenator
Merge pull request #334 from pjreed/265-plugin-source-frames
f02929e 
Fix for #265; message source frames don't update (Indigo)
@pjreed pjreed closed this as completed Apr 11, 2016
malban pushed a commit to malban/mapviz that referenced this issue Jul 6, 2016
@evenator
Merge pull request swri-robotics#266 from swri-robotics/indigo-devel
9f7d7ef 
Resolves swri-robotics#265
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pjreed pjreed

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@malban @pjreed