add context menu to config_item #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 From me. I've always found that button unintuitive myself. |
|
Just a personal opinion. If this PR is eventually merged, may be you want to consider removing the Remove button on bottom and stop using orange to highlight the selected config_items. Up to you ;) |
|
👍 I like this, although I don't think the "Remove" button on bottom should be removed. In general I think that a context menu should never be the only way to access a function, since right-clicking not be available or may not work right on every platform, and it's not easily discoverable for users who don't expect to be able to right-click on everything. |
pjreed
approved these changes
Nov 7, 2017
pjreed
pushed a commit
to pjreed/mapviz
that referenced
this pull request
Nov 9, 2017
* add context menu to config_item * typo fix * Change pointer syntax to match repository conventions * Change pointer syntax to match conventions
pjreed
added a commit
that referenced
this pull request
Nov 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I found the Remove button very counter intuitive, in particular when the config_item is collapsed.
I hope you will find this PR useful.
Regards
Davide